fix: preserve stylesheet base URL in shadow roots - #10746
Open
cdeil wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
When
copyStylesserializes a linked stylesheet into a constructed stylesheet for a component shadow root, WebKit resolves relative font URLs against the document directory instead of the source stylesheet. Nested static exports therefore request bundled fonts from the lesson root and receive 404 responses.This change:
baseURL: sheet.href ?? document.baseURIregisterReactComponentpathCSSStyleSheetInit.baseURL is the CSSOM mechanism for setting the base URL used to resolve relative URLs.
🔬 Verification
main; the 14 existing focused tests pass.make check, frontend lint, type-check, and production build pass.html-wasmexport:📋 Pre-Review Checklist
✅ Merge Checklist