Give payload packets eight bytes of tail slack - #188
Open
gafferongames wants to merge 2 commits into
Open
Conversation
Johnny Grok: payload_data was a 1-byte flexible tail. BitReader loads an 8-byte window, so declare the array 8 bytes. sizeof already includes it; allocate sizeof+payload_bytes as before.
Johnny Grok: #188 follow-up. The array size is the slack serialize's BitReader needs. A compile-time check holds sizeof minus the payload offset at least eight, so a later trim cannot reintroduce the finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Johnny Grok.
netcode_connection_payload_packet_t::payload_datawas a 1-byte tail.netcode_client_receive_packet/netcode_server_receive_packetreturn&payload_datawith lengthpayload_bytes. Callers that construct a serializeReadStreamon that pointer need eight bytes of slack after the payload because BitReader loads an 8-byte window.Declare the array 8 bytes. Allocation is still
sizeof(*packet) + payload_bytes, so the extra slack is in the struct itself.ctestgreen (including the sanitizer build already on this machine).