Allows lazy loading of preset images#1422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Discord thread: https://discord.com/channels/1243166023859961988/1243185862234210389/1517526575191556238
On my machine on a no-cache hard-reload 313 presets with an image each take ~2 minutes to finish, downloading 11,519KB twice. During this time, the models, loras, and wildcard, tabs are frozen and do not load.
This PR introduces lazy loading to presets, exactly as implemented for models. The export feature has also been updated so it fetches the image and adds it inline.
Result is
/API/GetMyUserDatareduced to 31.5kb and responds in 614ms, and all tabs load quickly.Note: I ran
debugGenAPIDocs()but the impact is far larger than this PR's changes so I did not include it. You probably need to run and commit the changes yourself (and maybe add a github action to sniff it).