feat: migrate buttons to bbb-ui-components-react lib#10
Open
guiiBecker wants to merge 6 commits into
Open
Conversation
…ticDefaultImports
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
germanocaumo
requested changes
Jul 1, 2026
germanocaumo
left a comment
germanocaumo
left a comment
There was a problem hiding this comment.
npm install is failing (also can be seen in CI logs):
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @mui/icons-material@7.3.11
npm error Found: @mui/material@7.3.1
npm error node_modules/@mui/material
npm error @mui/material@"7.3.1" from the root project
npm error peer @mui/material@"^7.3.1" from @mconf/bbb-ui-components-react@2.1.0
npm error node_modules/@mconf/bbb-ui-components-react
npm error @mconf/bbb-ui-components-react@"2.1.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @mui/material@"^7.3.11" from @mui/icons-material@7.3.11
npm error node_modules/@mui/icons-material
npm error peer @mui/icons-material@"^7.3.1" from @mconf/bbb-ui-components-react@2.1.0
npm error node_modules/@mconf/bbb-ui-components-react
npm error @mconf/bbb-ui-components-react@"2.1.0" from the root project
npm error
npm error Conflicting peer dependency: @mui/material@7.3.11
npm error node_modules/@mui/material
npm error peer @mui/material@"^7.3.11" from @mui/icons-material@7.3.11
npm error node_modules/@mui/icons-material
npm error peer @mui/icons-material@"^7.3.1" from @mconf/bbb-ui-components-react@2.1.0
npm error node_modules/@mconf/bbb-ui-components-react
npm error @mconf/bbb-ui-components-react@"2.1.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/mconf/.npm/_logs/2026-07-01T13_52_40_212Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/mconf/.npm/_logs/2026-07-01T13_52_40_212Z-debug-0.log
Also, why you pinned just some of the depencies and not all?
germanocaumo
requested changes
Jul 1, 2026
germanocaumo
left a comment
germanocaumo
left a comment
There was a problem hiding this comment.
padding between line and button is smaller than before:
| return true; | ||
| }) | ||
| .map((token) => { | ||
| // Remove common punctuation from each word (including parentheses, brackets, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates the component library import to use the canonical package name aligning with the import pattern used in the main application.