Conversation
huyanxius
marked this pull request as ready for review
October 3, 2026 07:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code-block language selector and delete button sit over the first code line. Long lines can therefore be hidden even while editing or in read-only mode, as reported in #748.
The toolbar uses the shared absolutely positioned nested-editor toolbar mixin, while the CodeMirror content reserves no space for it.
Changes
The shared mixin and other nested editors are unchanged. No public API or focus/event-handler changes are involved.
Layout trade-off
Code blocks become taller by one toolbar row. This deliberately keeps both the first line and the controls visible while editing. The earlier issue discussion suggested a hover option; this proposes a CSS-only default layout fix instead, since showing an overlay on hover/focus would still obscure the code during use.
Verification
122347cff8af5e9e1291b52789d22ed3ba0dc2ba, Chromium, Firefox, and WebKit each failed specifically at the first-line/toolbar geometry assertion. The validation also rejects setup errors or other failure causes.setTimeout.npm run lint,npm run typecheck, andnpm run build: passed.git diff --check: passed.The three files here are byte-for-byte identical to those validated on the fork. The fork-only CI harness is excluded from this PR.
Fixes #748