chore(deps): bump mega-evm to v1.7.2 on release-v2.0.19 - #229
Conversation
Co-authored-by: mega-putin[bot] <mega-putin[bot]@users.noreply.github.com> (cherry picked from commit bcf6603)
Claude review status
🛠️ Review did not finish Attempted head This round did not publish: MODEL_ACTION_FAILED in phase review_retry. Anything listed below is from the last round that did. Re-run the workflow or push a new commit to try again. |
Generated-by: engineer-agent
|
🔧 Pushed CI fixes. Agent log |
|
No additional actionable review feedback or questions were present. The only comment says the Claude review did not finish on old head No new commit was needed. |
Claude review status
✅ Review clean Last reviewed: head New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeb5a67c24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - uses: actions/create-github-app-token@v3 | ||
| id: app-token | ||
| with: | ||
| client-id: ${{ vars.MEGA_MAXWELL_CLIENT_ID }} |
There was a problem hiding this comment.
Configure the app-token action with
app-id
actions/create-github-app-token@v3 requires its GitHub App identifier through the app-id input; client-id is not an action input and is ignored. Consequently every pr-review run reaches this step without the required app ID and fails before checkout or the reviewer action can run. Pass the existing client-ID variable as app-id (GitHub accepts a client ID for the JWT issuer) or provide the numeric app ID through that input.
Useful? React with 👍 / 👎.
| (github.event_name == 'issue_comment' && | ||
| github.event.issue.pull_request != null && |
There was a problem hiding this comment.
Put the comment-review handler on the default branch
GitHub evaluates issue_comment workflows from the repository’s default branch, not from the PR’s head or its release target. This commit’s parent/default main still has the old pr-review condition that rejects issue_comment, so comments (including the edited mega-putin response this change is intended to process) on the release PR will not start this job until the same workflow change is first present on main. Land the handler on the default branch before relying on it for release-branch PR feedback.
Useful? React with 👍 / 👎.
| # in an inconsistent state. | ||
| concurrency: | ||
| group: claude-pr-review-${{ github.event.pull_request.number }} | ||
| group: claude-pr-review-${{ github.event.pull_request.number || github.event.issue.number }}-${{ github.event_name == 'pull_request' && 'code' || 'comment' }} |
There was a problem hiding this comment.
Serialize all review triggers for each pull request
When a PR is synchronized while a qualifying issue comment is created or edited, these expressions place the two pr-review runs in different code and comment concurrency groups, so GitHub can execute them simultaneously. Both invoke the shared reviewer with the CI app identity intended to resolve stale threads, allowing overlapping runs to race on the same review state and defeating the per-PR serialization described immediately above. Use a single group keyed only by the PR number.
Useful? React with 👍 / 👎.
|
@chatgpt-codex-connector[bot] ❓ Should I change this release PR’s (I've paused on this task. Reply here with the answer and I'll continue where I left off.) |
Summary
Cherry-pick of mega-evm
v1.7.0→v1.7.2ontorelease-v2.0.19(the 2.0.15 line).Trunk: #227 (
bcf6603).Cargo.tomlworkspace pin andCargo.lock(mega-evm/mega-system-contracts) now point at tagv1.7.2(faf6f2d7). Workspace version is not changed here — that stays on the candidate PR.Test plan
Cargo.tomlhastag = "v1.7.2"?tag=v1.7.2#faf6f2d7…