feat(mcp)!: accept host implementation and logger options - #54
Merged
Merged
Conversation
mcpserver.New now requires Options as a third argument so hosts can advertise application identity and supply a slog logger. A nil Implementation keeps Name "codemode" and Version "2".
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Allow hosts to supply MCP implementation metadata and SDK diagnostics through required construction options. Migrate every example and callsite; preserve the three-tool surface and existing authorization/error boundaries.
Verification
An isolated executable verified custom name/title/version over MCP initialization, host logger output, and real worker-backed composition returning 6. Local root:check is running; CI must pass before merge.
Compatibility
New now requires a third Options argument. Options{} retains the library identity and SDK logger defaults.