fix(heltec_t114): correct swapped P0.X comments on Wire1 I2C pins#2760
Open
tahnok wants to merge 1 commit into
Open
fix(heltec_t114): correct swapped P0.X comments on Wire1 I2C pins#2760tahnok wants to merge 1 commit into
tahnok wants to merge 1 commit into
Conversation
The PIN_WIRE1_SDA/SCL comments were swapped and wrong: pin 7 was labelled P0.8 and pin 8 labelled P0.7. Per g_ADigitalPinMap (1:1 for pins >= 2), Arduino pin 7 = P0.07 and pin 8 = P0.08. Wire1 is the environment-sensor bus (ENV_PIN_SDA/SCL), so the misleading comments can lead users to wire INA219/other sensors with SDA/SCL reversed, which prevents the sensor from responding and can hang the I2C scan in EnvironmentSensorManager::begin() at boot. Comment-only change; no electrical/behavioral change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the
// P0.Xcomments on the T114Wire1I2C pins invariants/heltec_t114/variant.h. They were swapped and wrong:Per
g_ADigitalPinMapinvariant.cpp(1:1 for pins ≥ 2), Arduino pin 7 = P0.07 and pin 8 = P0.08. The old comments labelled pin 7 as P0.8 and pin 8 as P0.7 — both wrong, and swapped relative to each other.Why it matters
Wire1is the environment-sensor bus (ENV_PIN_SDA/ENV_PIN_SCLin the T114platformio.ini). The misleading comments lead users to wire INA219 / other I2C sensors with SDA and SCL reversed. A reversed bus means the sensor never ACKs, and on the nRF52 TWIM a stuck/miswired bus can block inside the I2C scan inEnvironmentSensorManager::begin(), which runs insetup()before the USB CLI is serviced — so the device appears to "lock up" / stop responding to USB configuration whenever the sensor is plugged in.The wrong comments date back to the sensor-management refactor (commit
5cb26b91) and have never been corrected.Scope
Comment-only change. No electrical or behavioral change to the firmware.
🤖 Generated with Claude Code