Add ESP32 Reset Reason to existing pwrmgt.bootreason cli command#2765
Open
fizzyfuzzle wants to merge 1 commit into
Open
Add ESP32 Reset Reason to existing pwrmgt.bootreason cli command#2765fizzyfuzzle wants to merge 1 commit into
fizzyfuzzle wants to merge 1 commit into
Conversation
Contributor
|
Yah, enjoy. |
Author
|
@liamcottle This is a small PR to add the 'reset reason' for ESP32 boards to the pwrmgt.bootreason cli. Would it be possible for this PR to get reviewed? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR will add the Reset Reason functionality to the pwrmgt.bootreason CLI command for ESP32 based devices. Currently this was implemented for nRF52 devices only.
All the code was already in the current firmware except the ESP32 implementation of the getResetReason() method on the board level.
MeshCore/src/MeshCore.h
Line 74 in 29f0a7f
This should help with ESP32 boards that have rebooted for unknown reason e.g. during the test of new firmware ;)
Code is copied from https://github.com/IoTThinks/EasySkyMesh, so credits go to @IoTThinks (Thanks for this 👍 )
IoTThinks@f25db3a