Skip to content

Better Label Update Strategie naming #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majst01 merged 1 commit into from
Jul 3, 2026
+139 −138
Merged

Better Label Update Strategie naming #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 39 additions & 39 deletions doc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,19 +270,19 @@ <h2>Table of Contents</h2>
</li>

<li>
<a href="#metalstack.api.v2.Meta"><span class="badge">M</span>Meta</a>
<a href="#metalstack.api.v2.LabelsPatch"><span class="badge">M</span>LabelsPatch</a>
</li>

<li>
<a href="#metalstack.api.v2.Paging"><span class="badge">M</span>Paging</a>
<a href="#metalstack.api.v2.Meta"><span class="badge">M</span>Meta</a>
</li>

<li>
<a href="#metalstack.api.v2.UpdateLabels"><span class="badge">M</span>UpdateLabels</a>
<a href="#metalstack.api.v2.Paging"><span class="badge">M</span>Paging</a>
</li>

<li>
<a href="#metalstack.api.v2.UpdateLabelsIndividually"><span class="badge">M</span>UpdateLabelsIndividually</a>
<a href="#metalstack.api.v2.UpdateLabels"><span class="badge">M</span>UpdateLabels</a>
</li>

<li>
Expand Down Expand Up @@ -3016,6 +3016,37 @@ <h3 id="metalstack.api.v2.Labels.LabelsEntry">Labels.LabelsEntry</h3>



<h3 id="metalstack.api.v2.LabelsPatch">LabelsPatch</h3>
<p>LabelsPatch adds, updates or remove given labels without modifying others</p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>update</td>
<td><a href="#metalstack.api.v2.Labels">Labels</a></td>
<td></td>
<td><p>Update labels. New ones will be added, existing ones overwritten </p></td>
</tr>

<tr>
<td>remove</td>
<td><a href="#string">string</a></td>
<td>repeated</td>
<td><p>Remove labels by key </p></td>
</tr>

</tbody>
</table>





<h3 id="metalstack.api.v2.Meta">Meta</h3>
<p>Meta of a message</p>

Expand Down Expand Up @@ -3116,45 +3147,14 @@ <h3 id="metalstack.api.v2.UpdateLabels">UpdateLabels</h3>
<td>replace</td>
<td><a href="#metalstack.api.v2.Labels">Labels</a></td>
<td></td>
<td><p>Labels replaces existing labels with the given ones </p></td>
</tr>

<tr>
<td>individual</td>
<td><a href="#metalstack.api.v2.UpdateLabelsIndividually">UpdateLabelsIndividually</a></td>
<td></td>
<td><p>UpdateLabelsIndividually adds, updates or remove given labels without modifying others </p></td>
<td><p>Replace existing labels with the given ones </p></td>
</tr>

</tbody>
</table>





<h3 id="metalstack.api.v2.UpdateLabelsIndividually">UpdateLabelsIndividually</h3>
<p>UpdateLabelsIndividually adds, updates or remove given labels without modifying others</p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>update</td>
<td><a href="#metalstack.api.v2.Labels">Labels</a></td>
<td>patch</td>
<td><a href="#metalstack.api.v2.LabelsPatch">LabelsPatch</a></td>
<td></td>
<td><p>Update labels. New ones will be added, existing ones overwritten </p></td>
</tr>

<tr>
<td>remove</td>
<td><a href="#string">string</a></td>
<td>repeated</td>
<td><p>Remove labels by key </p></td>
<td><p>Patch adds, updates or remove given labels without modifying others </p></td>
</tr>

</tbody>
Expand Down
66 changes: 32 additions & 34 deletions go/metalstack/api/v2/common.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions js/metalstack/api/v2/common_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,26 +101,26 @@ export declare const MetaSchema: GenMessage<Meta>;
*/
export type UpdateLabels = Message<"metalstack.api.v2.UpdateLabels"> & {
/**
* strategy defines the label update strategy
* Strategy defines the label update strategy
*
* @generated from oneof metalstack.api.v2.UpdateLabels.strategy
*/
strategy: {
/**
* Labels replaces existing labels with the given ones
* Replace existing labels with the given ones
*
* @generated from field: metalstack.api.v2.Labels replace = 1;
*/
value: Labels;
case: "replace";
} | {
/**
* UpdateLabelsIndividually adds, updates or remove given labels without modifying others
* Patch adds, updates or remove given labels without modifying others
*
* @generated from field: metalstack.api.v2.UpdateLabelsIndividually individual = 2;
* @generated from field: metalstack.api.v2.LabelsPatch patch = 2;
*/
value: UpdateLabelsIndividually;
case: "individual";
value: LabelsPatch;
case: "patch";
} | {
case: undefined;
value?: undefined;
Expand All @@ -132,11 +132,11 @@ export type UpdateLabels = Message<"metalstack.api.v2.UpdateLabels"> & {
*/
export declare const UpdateLabelsSchema: GenMessage<UpdateLabels>;
/**
* UpdateLabelsIndividually adds, updates or remove given labels without modifying others
* LabelsPatch adds, updates or remove given labels without modifying others
*
* @generated from message metalstack.api.v2.UpdateLabelsIndividually
* @generated from message metalstack.api.v2.LabelsPatch
*/
export type UpdateLabelsIndividually = Message<"metalstack.api.v2.UpdateLabelsIndividually"> & {
export type LabelsPatch = Message<"metalstack.api.v2.LabelsPatch"> & {
/**
* Update labels. New ones will be added, existing ones overwritten
*
Expand All @@ -151,10 +151,10 @@ export type UpdateLabelsIndividually = Message<"metalstack.api.v2.UpdateLabelsIn
remove: string[];
};
/**
* Describes the message metalstack.api.v2.UpdateLabelsIndividually.
* Use `create(UpdateLabelsIndividuallySchema)` to create a new message.
* Describes the message metalstack.api.v2.LabelsPatch.
* Use `create(LabelsPatchSchema)` to create a new message.
*/
export declare const UpdateLabelsIndividuallySchema: GenMessage<UpdateLabelsIndividually>;
export declare const LabelsPatchSchema: GenMessage<LabelsPatch>;
/**
* UpdateMeta must be provided with every UpdateRequest to define how optimistic locking should be handled
*
Expand Down
Loading
Loading