Repository navigation
GenericSLM: Sync refresh waiter to connected SLM, not primary monitor - #1004
Merged
Merged
Conversation
…han always the primary monitor.
Member
|
Great catch, thanks! Out of curiosity, did this make a real difference to how an SLM behaves? |
Contributor
Author
|
For my particular setup (180Hz primary monitor, 60Hz SLM) it has. I add a settling delay after calls to DisplayImage() which previously had to absorb the inconsistency but now I can give it ~20ms less headroom. I imagine the effect would be less pronounced if the refresh rates were more aligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously RefreshWaiter was associated with the active display driver when it was instantiated, meaning the calls to RefreshWaiter::WaitForVerticalBlank() within GenericSLM::DisplayImage() were polling the primary monitor. Since the SLM is practically never the primary monitor, the image updates would have been timed against an unrelated refresh rate.
Now RefreshWaiter can be bound to a specific monitor by GDI device name via SetMonitor. DirectDrawEnumerateExA is used to identify the correct device via its GDI device name.