Skip to content

ASIStage: keep the sign of CRISP values, limit Calibration Gain to int16 - #1005

Open
bls337 wants to merge 1 commit into
micro-manager:mainfrom
bls337:ASIStage
Open

bls337 wants to merge 1 commit into
micro-manager:mainfrom
bls337:ASIStage

Conversation

@bls337

@bls337 bls337 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

CRISP::GetValue skipped every non-digit before atof, so it dropped the minus sign along with the ":A " prefix: ":A -5 " read as 5. Values read through GetValue that can be negative:

  • GetOffset() and the Lock Offset property (LK Z?)
  • Dither Error on firmware 9.2o and later (LK Y?)
  • Calibration Gain (LR X?)

Now, when a '-' sits directly before the first digit, it keeps the minus sign.

The controller stores "Calibration Gain" as a signed 16-bit value, the property now has limits of INT16_MIN..INT16_MAX.

Tested on an MS-2000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant