Preserve parsed range nodes when expanding an AST - #69
Open
oyeong011 wants to merge 1 commit into
Open
Conversation
Expanding braces.parse("x{1..3}") deletes the range children and rewrites separator types, so subsequent public stringify/compile/expand calls lose the range. Remove those two destructive mutations; existing per-run queues still reset.
Confidence: high
Scope-risk: narrow
Tested: Regression red/green, full test suite, exported API QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding braces.parse("x{1..3}") deletes the range children and rewrites separator types, so subsequent public stringify/compile/expand calls lose the range. Remove those two destructive mutations; existing per-run queues still reset.
The regression fails before the change and passes afterward. Coverage includes numeric, alphabetic, descending, and combined set/range ASTs across public operations.
Validation: 895 tests.
AI assistance: OpenAI Codex was used to investigate, implement, and run the regression and full-suite checks.