Conversation
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/nycThe overall line coverage in commit 6b3bc3e in the Show a line coverage summary of the most covered files.
Updated |
mrmlnc
marked this pull request as ready for review
August 24, 2026 21:22
mrmlnc
marked this pull request as draft
August 24, 2026 22:08
mrmlnc
force-pushed
the
fg-405
branch
4 times, most recently
from
August 25, 2026 09:35
8ed4726 to
73b5a72
Compare
mrmlnc
marked this pull request as ready for review
August 25, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix leading-dot handling for direct brace alternatives that begin with a star wildcard (
*) or a negated extglob (!(...)) when the brace group starts a path segment.Previously, these alternatives were not recognized as segment starts because their preceding token is
{or,rather than the beginning of the pattern or/. As a result, they could match dotfiles even whendotwas disabled.This fixes the pattern reported in
mrmlnc/fast-glob#405:Implementation
When parsing an ordinary
*or!(...), use the existing brace stack and token chain to determine whether the token belongs to a direct brace alternative at the beginning of a path segment.This allows the parser to:
*from the*(...)extglob;*(...)matches;bash,dot, andnoextglobbehavior.No additional parser metadata is introduced.
Scope
This change handles direct, flat brace alternatives only.
Nested-brace alternatives such as
{a,{*.js,b}}remain outside its scope. Supporting them requires propagating path-segment context through enclosing brace groups. An alternative implementation covering that case is available inmicromatch/picomatch#193.Refs
mrmlnc/fast-glob#405