-
Notifications
You must be signed in to change notification settings - Fork 35
Stop requesting Observability API permissions for blueprint agents by default #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Krishnadheeraj (DheerajPannala)
wants to merge
19
commits into
main
Choose a base branch
from
users/DheerajPannala/skip-observability-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bacea97
Add --skip-observability-permissions to setup all
DheerajPannala 2d6f389
Make skipping Observability permissions the default for blueprint agents
DheerajPannala 2b5766a
Stop requesting Observability permissions in every blueprint auth mode
DheerajPannala 9e72b1b
Address #501 review: registration and consent edge cases
DheerajPannala cd937db
Condense #501 changelog entries and refresh stale test wording
DheerajPannala 3d54061
Scope the Observability upgrade note to delegated-route agents
DheerajPannala d5bac12
Merge origin/main into skip-observability-permissions
DheerajPannala 0c9a890
Address #501 review: s2s/both summary and failed app-role hand-off
DheerajPannala 882be8e
Align #501 docs with the s2s/both summary
DheerajPannala 7367ee5
List a hand-off per failed S2S target in the setup summary
DheerajPannala 55e3e77
Qualify the s2s/both README note and de-duplicate pending roles
DheerajPannala e88c109
Address observability S2S review feedback
DheerajPannala 5ebda8f
Clarify delegated-route upgrade note
DheerajPannala f33cfda
Keep the setup admin removal note and fix the missing-secret retry ad…
DheerajPannala d81c735
Merge origin/main (#478 cloud-aware endpoints) into skip-observabilit…
DheerajPannala 39b2b3c
Point the Observability opt-back-in command at the cloud's app ID
DheerajPannala 69fb074
Address observability opt-back-in review
DheerajPannala 6b0a0fd
Tighten observability opt-back-in handling
DheerajPannala b21addd
Record the auth mode before the agent identity step
DheerajPannala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question] This note used to target existing agents, whose blueprints already had an Observability entry in their inheritable permissions. It now also covers new blueprint agents on the delegated route, and after this PR
setup alldoesn't stamp that entry for them.For a blueprint created after this change, does Option A alone (delegated and application OtelWrite plus admin consent on the blueprint app) give the agent identity OtelWrite through the delegated route? Without the inheritable-permission entry I'd expect it not to, and requiredResourceAccess isn't supported for Agent Blueprints. If it doesn't, could the note point to
a365 setup permissions custom --resource-app-id 9b975845-388f-4429-889e-eab1ef63949c --scopes Agent365.Observability.OtelWrite, which stamps it as an inheritable permission and requests consent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed: Option A relies on the Observability inheritable-permission entry, which
setup allno longer stamps for new blueprint agents. Fixed in e88c109, 5ebda8f and f33cfda:a365 setup adminwas removed. For blueprint agents created after this release, it runsa365 setup permissions custom --resource-app-id <Observability app ID for your cloud> --scopes Agent365.Observability.OtelWrite, which stamps the inheritable permission and requests consent (PermissionsSubcommand→SetupHelpers.EnsureResourcePermissionsAsync→SetInheritablePermissionsAsync).