Fixing bug that was hiding error messages when publish and unpublish happen

[deepaligargms]

What

a365 develop-mcp publish printed ERROR: Failed to publish ...: No response received on
every failure — a duplicate-instance rejection, a 400 validation error, or a downstream
5xx all looked identical, with the actual server message thrown away.

Root cause: Agent365ToolingService.PublishServerAsync did return null; on failure,
discarding the responseContent that ValidateResponseAsync had already extracted. The
executor then rendered publishResponse?.Message ?? "No response received" → the fallback
string, always.

Change

• New internal static BuildPublishFailureResponse(responseContent, statusCode, logger) that
  returns a populated PublishMcpServerResponse (Status = "Failed") carrying the real message.
  The publish failure branch now calls it instead of return null;.
• It handles the three body shapes the platform emits, in order:
  1. the { Status, Message } envelope — including double-serialized bodies, because the
     platform returns its already-JSON string via Ok(string), which re-serializes it
     (unwrapped by the existing DeserializeWithDoubleSerialization helper);
  2. ASP.NET { error[, details] } / { message } problem bodies (via ExtractErrorMessage,
     preferring details);
  3. fallback to Server returned {statusCode} when the body has no readable message.

This mirrors what AddServerAsync already does correctly — publish was the outlier.

Before / after

Before:
ERROR: Failed to publish MCP server msdyn_DataverseMCPServer: No response received

After (example — duplicate instance):
ERROR: Failed to publish MCP server msdyn_DataverseMCPServer: MCP server '...' is already
published in environment '...' under alias '...'. Only one published instance is allowed
per server.

Tests

7 new [Fact]s in Agent365ToolingServicePureFunctionTests covering every branch:
double-serialized envelope, single-serialized envelope, {error} (400), {error,details}
(500, prefers details), empty body, null body, non-JSON body. Full pure-function +
publish/develop/tooling suites green (175 tests).

Reviewer notes

• No behavior change on the success path — PublishServerAsync still returns the deserialized
  success response; only the failure branch changed.
• ValidateResponseAsync already flags both non-2xx responses and 200 bodies whose envelope
  Status != "Success", so this correctly surfaces the platform's 200-with-Status:"Failed"
  rejection as well.

[github-actions]

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Krishnadheeraj (DheerajPannala)]

LGTM

[Copilot]

Copilot review overview

🟡 Changes recommended

Status envelopes containing only Error still lose the server message, and the user-facing fix lacks a changelog entry.

Review effort: Balanced
Findings: 1 · 3

Open (4)

• Preserve envelope Error in successful response validation · New
• Shorten summary to comply with repository guidance · New
• Add behavioral fix to the Unreleased changelog · New
• Explain double-serialization assertion with because clause · New

What changed in this PR

Improves develop-mcp publish failures by preserving server-provided error messages.

Changes:

• Parses envelope, problem-detail, and fallback error responses.
• Adds seven parsing regression tests.

File	Description
Agent365ToolingService.cs	Builds populated publish failure responses.
Agent365ToolingServicePureFunctionTests.cs	Tests supported failure-body formats.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.