[#682] Samples Parity: Align Cards samples - #736
Merged
tracyboehrer (tracyboehrer) merged 6 commits intoSep 22, 2026
Merged
Conversation
tracyboehrer (tracyboehrer)
approved these changes
Sep 22, 2026
Copilot started reviewing on behalf of
Cecilia Avila (ceciliaavila)
September 22, 2026 16:48
View session
tracyboehrer (tracyboehrer)
deleted the
southworks/update/parity-cards-samples
branch
September 22, 2026 16:51
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Four moderate review findings remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR aligns the Cards samples across Python, Node.js, and .NET, adding a complete .NET implementation and synchronizing behavior, configuration, and documentation.
Changes:
- Aligns routing, commands, card content, and resource loading.
- Adds the .NET Cards sample with authentication, hosting, seven card types, and manifest registration.
- Updates documentation, package metadata, solution registration, and Dependabot configuration.
Review findings:
- Moderate (1 vote):
AspNetExtensions.cscan throw on malformed bearer headers before JWT validation; parsing should fail cleanly. - Moderate (1 vote):
CardMessages.csloadsadaptive_card.jsonfrom output, but the resource is not copied there. - Moderate (2 votes):
Cards.csprojmust configureadaptive_card.jsonfor output or use another deployment-safe loading mechanism. - Moderate (2 votes):
cardMessages.tspassesheroCardarguments in the wrong order, producing a malformed intro card without buttons.
| File | Summary |
|---|---|
samples/python/cards/src/start_server.py |
Adds a license header. |
samples/python/cards/src/card_messages.py |
Aligns menu labels and card content. |
samples/python/cards/src/agent.py |
Improves command parsing, welcome filtering, and resource loading. |
samples/python/cards/README.md |
Updates setup and usage documentation. |
samples/python/cards/env.TEMPLATE |
Documents environment configuration. |
samples/nodejs/cards/src/index.ts |
Aligns routing and command handling. |
samples/nodejs/cards/src/cardMessages.ts |
Updates card payloads and content. |
samples/nodejs/cards/README.md |
Updates setup and usage documentation. |
samples/nodejs/cards/package.json |
Renames and describes the sample package. |
samples/nodejs/cards/package-lock.json |
Synchronizes package metadata. |
samples/nodejs/cards/env.TEMPLATE |
Clarifies environment configuration. |
samples/nodejs/cards/.vscode/tasks.json |
Removes the previous task configuration. |
samples/nodejs/cards/.vscode/launch.json |
Removes the previous launch configuration. |
samples/dotnet/Samples.sln |
Registers the Cards project. |
samples/dotnet/README.md |
Adds the Cards catalog entry. |
samples/dotnet/cards/Resources/adaptive_card.json |
Adds the shared Adaptive Card resource. |
samples/dotnet/cards/README.md |
Documents the .NET sample. |
samples/dotnet/cards/Properties/launchSettings.json |
Adds local launch profiles. |
samples/dotnet/cards/Program.cs |
Configures hosting, authorization, and storage. |
samples/dotnet/cards/CardsAgent.cs |
Implements routing and card selection. |
samples/dotnet/cards/Cards.csproj |
Adds project configuration and dependencies. |
samples/dotnet/cards/CardMessages.cs |
Implements seven card types. |
samples/dotnet/cards/AspNetExtensions.cs |
Adds JWT authentication configuration. |
samples/dotnet/cards/appsettings.json |
Adds authentication and service configuration. |
samples/dotnet/cards/appManifest/manifest.json |
Adds the Teams app manifest. |
.github/dependabot.yml |
Adds the .NET Cards directory to Dependabot. |
Files not reviewed (1)
- samples/nodejs/cards/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #682
Description
This PR aligns the Cards samples for all three languages (.NET, JavaScript, and Python).
Detailed Changes
Testing
These images show the samples working with an exact user interaction.