Trace Parser: authorize trace deletion in the web server - #560
Open
ahmetziyayildirim wants to merge 1 commit into
Open
ahmetziyayildirim wants to merge 1 commit into
ahmetziyayildirim wants to merge 1 commit into
Conversation
Keep DAB analysis read-only and execute trace deletion through a tenant-checked server service with a restricted SQL connection. Confirm completion across incremental batches and cover authorization and failure paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f085bfc-844d-4ec3-9391-b696cf6d0e6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deployment policy
Deletion is disabled until TraceAdministration:SqlConnectionString is configured. The documented SQL principal requires only EXECUTE on dbo.sp_DeleteTrace and SELECT on dbo.Traces. Every authenticated user admitted to the configured tenant can delete traces; this is not a per-owner or administrator-only policy.
Stacked on #559. Review this PR against its current base for the deletion-only diff; merge the preceding change first and retarget as appropriate. No SQL procedure replacement is included.