Skip to content

[2/5] Add agent-scoped announcement models and authoring client #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SophieS0ng merged 2 commits into from
Sep 24, 2026
Merged

[2/5] Add agent-scoped announcement models and authoring client #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36beae9
feat(announcements): add agent-scoped authoring contracts
ReillyBova Sep 11, 2026
0c8a658
fix(announcements): preserve repairable read-only draft inputs
rebova-microsoft Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,31 @@ jobs:
node extension.test.js
npm run validate

org-announcements:

@rebova-microsoft rebova-microsoft Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough — Give the new client and models their own automated checks.

This adds an Org Announcements job that sets up Python 3.11, installs the development and feature dependencies, and selects the authoring-client and draft-model tests. Keeping those two files explicit lets this layer be checked before the later directory and MCP runtime pieces are added. It describes what CI will run; it is not a deployment step or a statement that the tests have passed.

name: Org Announcements configuration
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.11'

- name: Install Python dependencies
run: >-
pip install
-r requirements-dev.txt
-r solutions/ess-maker-skills/src/mcp/agentconfig_org_announcements/requirements.txt

- name: Run Org Announcements tests
run: >-
python -m pytest
tests/mcp/agentconfig_org_announcements/test_authoring_client.py
tests/mcp/agentconfig_org_announcements/test_drafts.py
-q

flightcheck-tests:
name: FlightCheck offline test suite
runs-on: ubuntu-latest
Expand Down
12 changes: 12 additions & 0 deletions solutions/ess-maker-skills/src/mcp/agentconfig_org_announcements/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Compiled Python
__pycache__/
*.pyc

# This server owns NO token cache of its own. It uses exactly the two shared
# delegated caches:
# - Microsoft Graph -> solutions/ess-maker-skills/.local/.token_cache.bin
# - AgentConfiguration -> src/mcp/agentconfig_core/.local/msal_token_cache.bin
# both of which are ignored by their own directories' rules. This entry is
# belt-and-braces only: if anything ever drops local state here it must not be
# committed.
.local/

@rebova-microsoft rebova-microsoft Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough — Keep generated and local state out of source control.

The Python entries ignore compiled files, while .local/ is a precaution against accidentally adding local state under this feature folder. The accompanying note explains that this feature should reuse the existing shared authentication caches rather than create another private cache here. These rules only control what Git ignores; they do not create, move, or secure a token cache.

Loading
Loading