Skip to content

Read embedding settings from runtime config - #3102

Merged
Dominic Nguyen (datduyng) merged 1 commit into
mainfrom
domnguyen/knowpro-embedding-config-followup
Sep 30, 2026
Merged

Dominic Nguyen (datduyng) merged 1 commit into
mainfrom
domnguyen/knowpro-embedding-config-followup

Conversation

@datduyng

Copy link
Copy Markdown
Contributor

Follow-up to #3096.

  • embeddingProvider reads the embedding: section from the typed runtime config instead of process.env.
  • Config warns when a positive-integer setting (e.g. embedding.size) is invalid, instead of ignoring it silently.
  • getEmbeddingSize doc refers to the default-size constants, so it cannot drift.
  • createEmbeddingModel logs model/batch-size overrides of the pool settings (typeagent:openai).
  • KnowPro uses getEmbeddingSize() for caller-supplied models too, instead of a hardcoded 1536.

@robgruen robgruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Comment thread ts/packages/aiclient/src/embeddingProvider.ts
@datduyng
Dominic Nguyen (datduyng) added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit 468c9d2 Sep 30, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants