Read embedding settings from runtime config - #3102
Merged
Dominic Nguyen (datduyng) merged 1 commit intoSep 30, 2026
Merged
Conversation
Dominic Nguyen (datduyng)
marked this pull request as ready for review
September 29, 2026 21:23
Dominic Nguyen (datduyng)
requested review from
Hillary Mutisya (hillary-mutisya) and
robgruen
September 29, 2026 21:24
Dominic Nguyen (datduyng)
enabled auto-merge
September 29, 2026 21:31
Dominic Nguyen (datduyng)
disabled auto-merge
September 29, 2026 21:36
Hillary Mutisya (hillary-mutisya)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3096.
embeddingProviderreads theembedding:section from the typed runtime config instead ofprocess.env.embedding.size) is invalid, instead of ignoring it silently.getEmbeddingSizedoc refers to the default-size constants, so it cannot drift.createEmbeddingModellogs model/batch-size overrides of the pool settings (typeagent:openai).getEmbeddingSize()for caller-supplied models too, instead of a hardcoded 1536.