git-story: register git pre-commit hook - #3103
Closed
Dominic Nguyen (datduyng) wants to merge 2 commits into
Closed
Dominic Nguyen (datduyng) wants to merge 2 commits into
Dominic Nguyen (datduyng) wants to merge 2 commits into
Conversation
Contributor
Author
|
Split into #3104 (hook + init) and the test PR stacked on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3101.
git story initnow also writes apre-commitscript to the git hooks directory. The script runsexec git story hooks git pre-commit "$@", so git's hook arguments and stdin reach the command unchanged. The handler reads stdin and prints a placeholder.core.hooksPathand worktrees viagit rev-parse --git-path.Verified in a temp repo: commit fires the hook;
echo piped | .git/hooks/pre-commit a bprintsargs=["a","b"] stdin="piped\n"; re-run is idempotent; foreign hook is skipped.