Skip to content

Read embedding settings from runtime config - #3108

Draft
Dominic Nguyen (datduyng) wants to merge 4 commits into
mainfrom
domnguyen/embedding-runtime-config
Draft

Dominic Nguyen (datduyng) wants to merge 4 commits into
mainfrom
domnguyen/embedding-runtime-config

Conversation

@datduyng

Copy link
Copy Markdown
Contributor

Follow-up to #3096.

  • embeddingProvider reads the embedding: section from the typed runtime config instead of process.env. The config package already parses these env vars, so values set by env, .env, or YAML still apply.
  • The Copilot memory plugin rebuilds the runtime config after it removes copilot providers from env, so the removal still takes effect when the config is already cached.
  • Config warns when a positive-integer setting (e.g. embedding.size) is invalid.
  • getEmbeddingSize doc refers to the default-size constants.
  • createEmbeddingModel logs model/batch-size overrides (typeagent:openai).
  • KnowPro uses getEmbeddingSize() for caller-supplied models too, instead of a hardcoded 1536.

@datduyng
Dominic Nguyen (datduyng) force-pushed the domnguyen/embedding-runtime-config branch from c05dc83 to 42ec617 Compare September 29, 2026 23:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant