Read embedding settings from runtime config - #3108
Draft
Dominic Nguyen (datduyng) wants to merge 4 commits into
Draft
Dominic Nguyen (datduyng) wants to merge 4 commits into
Dominic Nguyen (datduyng) wants to merge 4 commits into
Conversation
Dominic Nguyen (datduyng)
force-pushed
the
domnguyen/embedding-runtime-config
branch
from
September 29, 2026 23:49
c05dc83 to
42ec617
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3096.
embeddingProviderreads theembedding:section from the typed runtime config instead ofprocess.env. The config package already parses these env vars, so values set by env,.env, or YAML still apply.copilotproviders from env, so the removal still takes effect when the config is already cached.embedding.size) is invalid.getEmbeddingSizedoc refers to the default-size constants.createEmbeddingModellogs model/batch-size overrides (typeagent:openai).getEmbeddingSize()for caller-supplied models too, instead of a hardcoded 1536.