Add regression test for JSX runtime resolution in scripts - #64444
Closed
GermanoB (germanao) wants to merge 1 commit into
Closed
GermanoB (germanao) wants to merge 1 commit into
GermanoB (germanao) wants to merge 1 commit into
Conversation
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused regression test and generated baselines consistently validate the intended behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds regression coverage for JSX runtime resolution in script and module files.
Changes:
- Adds a NodeNext JSX runtime fixture.
- Confirms runtime
JSX.Elementand intrinsic symbol resolution. - Records expected type, symbol, and emit baselines.
| File | Description |
|---|---|
jsxRuntimeScriptDiagnostic.tsx |
Defines the regression scenario. |
jsxRuntimeScriptDiagnostic.types |
Verifies inferred JSX types. |
jsxRuntimeScriptDiagnostic.symbols |
Verifies intrinsic symbol resolution. |
jsxRuntimeScriptDiagnostic.js |
Records expected emit. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
GermanoB (germanao)
deleted the
fix-jsx-runtime-script-diagnostic-64438
branch
September 25, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsxImportSourcepointing to an installed runtime package.export {}and verify both resolveJSX.Elementfrom the runtime.Related to #64438. This PR adds regression coverage; it does not change compiler behavior or the wording of those diagnostics in TypeScript 6.0.3.
Validation
go -C ./tsc test -run 'TestLocal/jsxRuntimeScriptDiagnostic' ./internal/testrunner— passed.npx hereby check:format— passed.AI assistance
This PR was authored with Codex AI assistance. I will review the patch and handle maintainer feedback.