Repository navigation
fix(algos): Fixes infinite loop in mutate_parents when mutations are … - #257
Open
Madson Dias (omadson) wants to merge 1 commit into
Open
Madson Dias (omadson) wants to merge 1 commit into
Madson Dias (omadson) wants to merge 1 commit into
Conversation
Madson Dias (omadson)
requested review from
Gustavo de Rosa (gugarosa) and
Piero Kauffmann (piero2c)
as code owners
October 7, 2026 19:59
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
While testing the search algorithms I noticed that
LocalSearch,RegularizedEvolutionSearchandMoBananasSearchcan hang forever inmutate_parents: on an invalid mutation,continueskipsnb_tries += 1, sopatienceis never enforced.EvolutionParetoSearchhad the same bug and #225 fixed it. This applies the same fix to the other three.Tests
One new test per algorithm: all mutations are invalid and
mutatemust be called at mostpatiencetimes. They fail without the fix and pass with it (pytest tests/discrete_search/algos: 9 passed).Changes
Configuration:
Final checks: