feat(ai): add agent skill rendering core#287
Open
dmcilvaney wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the internal/app/azldev/agentskill “rendering core” that embeds and renders agent skill / instruction markdown from Go templates, so azldev can emit version-matched agent guidance via on-disk files, CLI output, and MCP responses.
Changes:
- Added the
agentskillpackage with registries for skills/instructions, embedding + rendering logic, and a default on-disk layout. - Added shared wrapper templates and an initial
azldevskill body template. - Added unit tests and authoring/maintenance instructions for keeping skills accurate and drift-resistant.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/app/azldev/agentskill/doc.go | Package-level documentation describing the registries, rendering modes, and maintenance model. |
| internal/app/azldev/agentskill/agentskill.go | Core registries + template rendering APIs (SkillDocument, Files, layout helpers). |
| internal/app/azldev/agentskill/agentskill_test.go | Tests validating front-matter invariants and wrapper/full rendering behavior. |
| internal/app/azldev/agentskill/content/skill-wrapper.md.tmpl | Generic “redirect wrapper” skill template pointing to the MCP tool / CLI. |
| internal/app/azldev/agentskill/content/instruction-wrapper.md.tmpl | Generic instruction wrapper template with applyTo and skill pointers. |
| internal/app/azldev/agentskill/content/azldev.md.tmpl | Initial full-body azldev skill template with command list substitution. |
| .github/instructions/agent-skills.instructions.md | New contributor guidance for adding/editing skills and wrappers and preventing drift. |
| .github/copilot-instructions.md | Notes that agent skills may need updates after CLI/config/workflow behavior changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part in the changes that allow azldev to emit its own agent instructions. End result: microsoft/azurelinux#17949