test: add telegraf container test#18000
Merged
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new container-base runtime validation for Telegraf by introducing a dedicated Dockerfile-based test case and a helper fixture for writing config files into the running test container.
Changes:
- Added a
write_file_in_containerpytest fixture to simplify writing arbitrary file content into the running container. - Introduced a new Telegraf runtime test suite that validates basic execution, version/usage reporting, and file output behavior.
- Added a Dockerfile and checked-in Telegraf configs used by the new tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| base/images/tests/conftest.py | Adds a fixture for writing content into the test container filesystem. |
| base/images/tests/cases/runtime/container-base/test_telegraf/test_telegraf.py | New Telegraf runtime tests exercising --test, --version/--usage, and file output plugin behavior. |
| base/images/tests/cases/runtime/container-base/test_telegraf/Dockerfile | Builds a test image layer installing Telegraf and placing a baseline config. |
| base/images/tests/cases/runtime/container-base/test_telegraf/configs/telegraf.conf | Baseline Telegraf config used for --test validation. |
| base/images/tests/cases/runtime/container-base/test_telegraf/configs/file_output.conf | Telegraf config enabling file output for metric flush verification. |
bhagyapathak
force-pushed
the
bhagya/telegraf-container-test
branch
from
July 13, 2026 08:43
77f6157 to
fa7d337
Compare
bhagyapathak
force-pushed
the
bhagya/telegraf-container-test
branch
from
July 13, 2026 09:07
fa7d337 to
e85de22
Compare
bhagyapathak
force-pushed
the
bhagya/telegraf-container-test
branch
from
July 13, 2026 09:19
e85de22 to
6c568bd
Compare
christopherco
requested changes
Jul 15, 2026
bhagyapathak
force-pushed
the
bhagya/telegraf-container-test
branch
from
July 15, 2026 08:35
6c568bd to
e37235e
Compare
|
|
||
|
|
||
| @pytest.fixture | ||
| def write_file_in_container(container_exec_shell): |
|
|
||
|
|
||
| @pytest.mark.dockerfile() | ||
| def test_telegraf_emits_mem_metrics(container_exec_shell) -> None: |
christopherco
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.