Skip to content

fix(openbios): restore aarch64 builds#18020

Open
christopherco wants to merge 1 commit into
4.0from
chrco/undo-openbios-workaround
Open

fix(openbios): restore aarch64 builds#18020
christopherco wants to merge 1 commit into
4.0from
chrco/undo-openbios-workaround

Conversation

@christopherco

@christopherco christopherco commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Backport upstream host bit-width detection to prevent forthstrap pointer
truncation on aarch64 and riscv64 builders. Remove the x86_64-only
workaround, use %autosetup, and track the rebuild with azl_release.

Upstream: openbios/openbios@e5ac46d
Reference: openbios/openbios#25

Fixes: AB#22404

Copilot-Session: 9541217f-798b-4299-8cd3-28fcb054e4eb

Copilot AI review requested due to automatic review settings July 15, 2026 06:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports OpenBIOS’s upstream host-width fix, enabling builds on aarch64 and riscv64 without pointer truncation.

Changes:

  • Applies the verified upstream patch and removes the x86_64 restriction.
  • Adds an Azure Linux release counter.
  • Updates generated specs and lock fingerprint.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/openbios/openbios.comp.toml Defines patch and release overlays.
base/comps/openbios/0001-*.patch Contains the upstream host-width fix.
specs/o/openbios/openbios.spec Renders patch application and release changes.
specs/o/openbios/0001-*.patch Rendered patch copy.
specs/o/openbios/openbios.azl.macros Defines azl_release.
locks/openbios.lock Refreshes the component fingerprint.

@christopherco
christopherco marked this pull request as ready for review July 16, 2026 05:14
@christopherco
christopherco requested a review from a team as a code owner July 16, 2026 05:14
@christopherco

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

Comment thread base/comps/openbios/openbios.comp.toml Outdated
type = "spec-add-tag"
tag = "ExclusiveArch"
value = "x86_64"
description = "Apply the OpenBIOS host bit-width detection patch"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): I would prefer using a spec-search-replace to change %setup to %autosetup so we don't have to remember to do these manual patches in the future.

Definitely non-blocking though.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good suggestion. Will work on this and update the PR

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use %autosetup

Copilot AI review requested due to automatic review settings July 17, 2026 03:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Backport upstream host bit-width detection to prevent forthstrap pointer
truncation on aarch64 and riscv64 builders. Remove the x86_64-only
workaround, use %autosetup, and track the rebuild with azl_release.

Upstream: openbios/openbios@e5ac46d
Signed-off-by: Chris Co <chrco@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9541217f-798b-4299-8cd3-28fcb054e4eb
@christopherco
christopherco force-pushed the chrco/undo-openbios-workaround branch from f023d56 to deec981 Compare July 17, 2026 05:06
@christopherco christopherco changed the title fix(openbios): backport host width fix fix(openbios): restore aarch64 builds Jul 17, 2026
@christopherco

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants