feat: make skills generally available#363
Merged
Merged
Conversation
Remove the editor preview feature flag dependency from Skills while retaining the Enable Skills preference. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Skills generally available by removing the “client preview feature” gating logic, while keeping the user-controlled Enable Skills preference as the sole toggle. This aligns the UI and settings logic so Skills can be enabled regardless of preview feature flag state.
Changes:
- Remove the client preview feature flag dependency from
PreferencesUtils.isSkillsEnabled(). - Always show the “Enable Skills” toggle on the Chat preferences page (no longer conditional on preview features).
- Add a unit test ensuring Skills can be enabled even when preview features are disabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/PreferencesUtils.java |
Simplifies Skills enablement logic to depend only on the ENABLE_SKILLS preference. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/ChatPreferencesPage.java |
Always renders the Skills preference field editor, removing preview-flag gating. |
com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/utils/SkillsPreferencesUtilsTest.java |
Adds regression coverage to ensure preview flags are not a prerequisite for Skills. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the editor preview feature flag dependency from Skills while retaining the Enable Skills preference.
fix #302