Skip to content

Users/ishagautam/add sales lead qualifier template - #15

Open
ishagautamMSFT wants to merge 15 commits into
mainfrom
users/ishagautam/add-sales-lead-qualifier-template
Open

ishagautamMSFT wants to merge 15 commits into
mainfrom
users/ishagautam/add-sales-lead-qualifier-template

Conversation

@ishagautamMSFT

Copy link
Copy Markdown
Collaborator
image image

@adrianatruji

Copy link
Copy Markdown
Collaborator

Review feedback

1. Personal email in NotifyEmail node.
The NotifyEmail configuration node currently contains a personal email address belonging to one of the contributors. Please replace it with a Contoso placeholder.

2. Trigger "Original mailbox address" field.
Same concern as the NotifyEmail node applies to the Original mailbox address in the trigger, it currently holds a specific value that shouldn't be shipped. A configuration note should be added in the node instructing the user to change this value to their own mailbox.

3. Logging Agent, Excel tools failing.
Same issue as observed elsewhere: the Excel tools in the Logging Agent aren't working.

4. Connector diversity.
This template and the Invoice Processing one feel very similar in shape. It would genuinely be worth considering a different set of connectors for the Sales Lead Qualifier to diversify the gallery.

@adrianatruji

Adriana Trujillo (adrianatruji) commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Hi ishagautamMSFT , couple notes:

  • The trigger does not include subject filter, therefore it is getting triggered by other emails too. Could you add this one?
  • The logging agent instructons are still failing. What worked for me again is the change we discussed: Set the file content to the base64-encoded string 'IA==' which decodes to space characters, and mark the content as base64-encoded. Do not use a literal space character, an empty string, or no content at all. The content parameter must be exactly the base64 value 'IA==' anothing else.

Thanks!

@ishagautamMSFT
ishagautamMSFT enabled auto-merge (squash) September 22, 2026 10:39
@adrianatruji

Adriana Trujillo (adrianatruji) commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks for the updates here, ishagautamMSFT ! The subject filter ("sales") and the "Loading..." folder config note on the trigger both look good and address the earlier points. File generation works well!

One regression to flag though: the trigger's mailboxAddress has reverted from the alias@contoso.com placeholder back to dawtcautomationtest@microsoft.com (a real internal test mailbox), and a hard-coded folderId (Id::AQMk...) has been re-added.
Could we switch the mailbox back to a Contoso placeholder before merge? The NotifyEmail variable is still correctly set to the placeholder, so it's just the trigger that slipped back.

One note worth adding:
Since now the Logging agent has instructions "You need three tables: HotLeads, WarmLeads, ColdLeads. " These do not get necessarily created in order based on which one was populated, so the user may think the row data was not added unless they scroll down or right (depending on if the agent decides to put the additional tables in some rows down, or some columns right, I have observed both cases).
image
Could we add a note in that node mentioning this?

Thank you!

@ishagautamMSFT

Copy link
Copy Markdown
Collaborator Author

Thanks for the updates here, ishagautamMSFT ! The subject filter ("sales") and the "Loading..." folder config note on the trigger both look good and address the earlier points. File generation works well!

One regression to flag though: the trigger's mailboxAddress has reverted from the alias@contoso.com placeholder back to dawtcautomationtest@microsoft.com (a real internal test mailbox), and a hard-coded folderId (Id::AQMk...) has been re-added. Could we switch the mailbox back to a Contoso placeholder before merge? The NotifyEmail variable is still correctly set to the placeholder, so it's just the trigger that slipped back.

One note worth adding: Since now the Logging agent has instructions "You need three tables: HotLeads, WarmLeads, ColdLeads. " These do not get necessarily created in order based on which one was populated, so the user may think the row data was not added unless they scroll down or right (depending on if the agent decides to put the additional tables in some rows down, or some columns right, I have observed both cases). image Could we add a note in that node mentioning this?

Thank you!

Adriana Trujillo (@adrianatruji) updated, could you take a look

@adrianatruji

Copy link
Copy Markdown
Collaborator

Thanks a lot, ishagautamMSFT ! Ready to merge too adilei

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants