Skip to content

Migrate Quota tools to new tool design#3066

Open
alzimmermsft wants to merge 3 commits into
microsoft:mainfrom
alzimmermsft:MigrateQuotaToolsToNewDesign
Open

Migrate Quota tools to new tool design#3066
alzimmermsft wants to merge 3 commits into
microsoft:mainfrom
alzimmermsft:MigrateQuotaToolsToNewDesign

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates Quota tools to new design where Register and Bind options are based on Option attributes.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@alzimmermsft alzimmermsft self-assigned this Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 16:04
@alzimmermsft
alzimmermsft requested review from a team, wchigit and xfz11 as code owners July 16, 2026 16:04
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Quota toolset’s commands and options to the newer attribute-based option binding model (OptionBinder) and updates the command implementations to the two-generic SubscriptionCommand<TOptions, TResult> pattern with subscription resolution.

Changes:

  • Converted Quota check and region availability list commands from RegisterOptions/BindOptions(ParseResult) to [Option]-attributed POCO options + ValidateOptions.
  • Removed legacy QuotaOptionDefinitions and tool-level GlobalUsings.cs in favor of explicit imports and new option binding.
  • Updated related helpers (primary constructors, minor cleanups) and added an Azure MCP Server changelog entry.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Quota/tests/Azure.Mcp.Tools.Quota.Tests/Commands/Usage/CheckCommandTests.cs Switches test base class to subscription-aware unit test base.
tools/Azure.Mcp.Tools.Quota/tests/Azure.Mcp.Tools.Quota.Tests/Commands/Region/AvailabilityListCommandTests.cs Updates test base class and adjusts invalid input testing.
tools/Azure.Mcp.Tools.Quota/src/Services/Util/Usage/ContainerAppUsageChecker.cs Minor cast style cleanup when mapping quota values.
tools/Azure.Mcp.Tools.Quota/src/Services/Util/JsonElementHelper.cs Adds explicit System.Text.Json using after removing global usings.
tools/Azure.Mcp.Tools.Quota/src/Services/Util/AzureUsageChecker.cs Adds explicit System.Text.Json using after removing global usings.
tools/Azure.Mcp.Tools.Quota/src/Services/Util/AzureRegionChecker.cs Refactors to primary constructors + minor list creation cleanup.
tools/Azure.Mcp.Tools.Quota/src/Options/Usage/CheckOptions.cs Migrates options to [Option] attributes + ISubscriptionOption.
tools/Azure.Mcp.Tools.Quota/src/Options/Region/AvailabilityListOptions.cs Migrates options to [Option] attributes + ISubscriptionOption.
tools/Azure.Mcp.Tools.Quota/src/Options/QuotaOptionDefinitions.cs Deletes legacy System.CommandLine option definitions.
tools/Azure.Mcp.Tools.Quota/src/GlobalUsings.cs Removes tool-scoped global using directives no longer needed.
tools/Azure.Mcp.Tools.Quota/src/Commands/Usage/CheckCommand.cs Converts to SubscriptionCommand<TOptions, TResult> + ValidateOptions.
tools/Azure.Mcp.Tools.Quota/src/Commands/Region/AvailabilityListCommand.cs Converts to SubscriptionCommand<TOptions, TResult> + ValidateOptions.
tools/Azure.Mcp.Tools.Quota/src/Commands/QuotaJsonContext.cs Simplifies JsonSerializerContext to file-scoped declaration.
servers/Azure.Mcp.Server/changelog-entries/1784217749433.yaml Adds changelog entry for Quota tool breaking change note.

Comment thread tools/Azure.Mcp.Tools.Quota/src/Options/Usage/CheckOptions.cs Outdated

@RickWinter RickWinter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR migrates the Quota commands to attribute-based option binding. The resource-type migration drops an accepted CLI input form, so that compatibility regression needs to be addressed before merge.

Comment thread tools/Azure.Mcp.Tools.Quota/src/Options/Usage/CheckOptions.cs Outdated
@alzimmermsft
alzimmermsft requested a review from RickWinter July 16, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants