Skip to content

Migrate MySql tools to new tool design#3069

Open
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateMySqlToolsToNewDesign
Open

Migrate MySql tools to new tool design#3069
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateMySqlToolsToNewDesign

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates MySql tools to new design where Register and Bind options are based on Option attributes.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@alzimmermsft alzimmermsft self-assigned this Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 17:26
@alzimmermsft
alzimmermsft requested review from a team, mattkohnms and ramnov as code owners July 16, 2026 17:26
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Azure MySql toolset from the legacy “RegisterOptions/BindOptions + System.CommandLine OptionDefinitions” pattern to the newer [Option]-attribute-based option binding used across the repo.

Changes:

  • Refactors MySql commands to use SubscriptionCommand<TOptions, TResult> with POCO options attributed via [Option].
  • Removes legacy MySql option/command base classes and System.CommandLine-specific option definition types from the toolset.
  • Updates unit tests and project references/dependencies to align with the new command + options shape.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Table/TableSchemaGetCommandTests.cs Updates command test base to the subscription-command test harness.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Services/MySqlServiceTests.cs Updates service construction after logger removal.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Services/MySqlServiceServerNameValidationTests.cs Updates service construction after logger removal.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerParamSetCommandTests.cs Updates command test base to the subscription-command test harness.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerParamGetCommandTests.cs Updates command test base to the subscription-command test harness.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerConfigGetCommandTests.cs Updates command test base to the subscription-command test harness.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/MySqlListCommandTests.cs Updates list command tests for new binding/test harness.
tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Database/DatabaseQueryCommandTests.cs Updates command test base to the subscription-command test harness.
tools/Azure.Mcp.Tools.MySql/src/Services/MySqlService.cs Removes logger dependency; keeps existing service behavior.
tools/Azure.Mcp.Tools.MySql/src/Options/BaseMySqlOptions.cs Replaces legacy JSON-property options with [Option]-attributed POCO options.
tools/Azure.Mcp.Tools.MySql/src/Options/MySqlListOptions.cs Adds new options type for list routing scenarios.
tools/Azure.Mcp.Tools.MySql/src/Options/MySqlOptionDescriptions.cs Introduces shared option description constants for reuse.
tools/Azure.Mcp.Tools.MySql/src/Options/MySqlOptionDefinitions.cs Removes legacy System.CommandLine Option<> definitions.
tools/Azure.Mcp.Tools.MySql/src/Options/Database/DatabaseQueryOptions.cs Migrates query option to [Option]-based binding.
tools/Azure.Mcp.Tools.MySql/src/Options/Database/DatabaseListOptions.cs Removes legacy options type.
tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerParamGetOptions.cs Migrates param-get options to [Option]-based binding.
tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerParamSetOptions.cs Migrates param-set options to [Option]-based binding.
tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerConfigGetOptions.cs Removes legacy options type.
tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerListOptions.cs Removes legacy options type.
tools/Azure.Mcp.Tools.MySql/src/Options/Table/TableSchemaGetOptions.cs Migrates table schema options to [Option]-based binding.
tools/Azure.Mcp.Tools.MySql/src/Options/Table/TableListOptions.cs Removes legacy options type.
tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlListCommand.cs Refactors to new subscription command design + POCO validation.
tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlJsonContext.cs Simplifies source-gen context definition syntax.
tools/Azure.Mcp.Tools.MySql/src/Commands/Database/DatabaseQueryCommand.cs Refactors to new subscription command design + POCO binding.
tools/Azure.Mcp.Tools.MySql/src/Commands/Database/BaseDatabaseCommand.cs Removes legacy command base class.
tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerConfigGetCommand.cs Refactors to new subscription command design + POCO binding.
tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerParamGetCommand.cs Refactors to new subscription command design + POCO binding.
tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerParamSetCommand.cs Refactors to new subscription command design + POCO binding.
tools/Azure.Mcp.Tools.MySql/src/Commands/Server/BaseServerCommand.cs Removes legacy command base class.
tools/Azure.Mcp.Tools.MySql/src/Commands/Table/TableSchemaGetCommand.cs Refactors to new subscription command design + POCO binding.
tools/Azure.Mcp.Tools.MySql/src/GlobalUsings.cs Removes legacy global using for System.CommandLine.
tools/Azure.Mcp.Tools.MySql/src/Azure.Mcp.Tools.MySql.csproj Updates core project reference style; drops direct System.CommandLine dependency.
servers/Azure.Mcp.Server/changelog-entries/1784222764751.yaml Adds breaking-change entry for MySql tool option surface changes.

Comment thread tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlListCommand.cs
Comment thread tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlListCommand.cs
Comment thread servers/Azure.Mcp.Server/changelog-entries/1784222764751.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants