Skip to content

Migrate Managed Lustre tools to new tool design#3078

Open
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateManagedLustreToolsToNewDesign
Open

Migrate Managed Lustre tools to new tool design#3078
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateManagedLustreToolsToNewDesign

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates Managed Lustre tools to new design where Register and Bind options are based on Option attributes.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@alzimmermsft alzimmermsft self-assigned this Jul 17, 2026
Copilot AI review requested due to automatic review settings July 17, 2026 12:54
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Azure Managed Lustre toolset to the attribute-based options design (where option registration/binding is derived from [Option] / [OptionContainer]), removing the legacy RegisterOptions/BindOptions + System.CommandLine option-definition pattern and updating tests accordingly.

Changes:

  • Converted Managed Lustre commands to the newer SubscriptionCommand<TOptions, TResult> execution model with attribute-based option POCOs.
  • Removed legacy option-definition and base-command infrastructure (ManagedLustreOptionDefinitions, BaseManagedLustreCommand, System.CommandLine dependency).
  • Updated Managed Lustre unit tests to use the newer command test base classes and explicit Xunit usings.

Reviewed changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/Usings.cs Removes global Xunit using; shifts tests to explicit using Xunit;.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/ManagedLustreHsmJobsCollection.cs Adds explicit Xunit using after global using removal.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/ManagedLustreCommandTests.cs Adds explicit Xunit using after global using removal.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/SubnetSize/SubnetSizeValidateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/SubnetSize/SubnetSizeAskCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/Sku/SkuGetCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobGetCommandTests.cs Updates tests for new result shape and new testing base.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobDeleteCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobCreateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobCancelCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemUpdateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemListCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemCreateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobGetCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobDeleteCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobCreateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobCancelCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobGetCommandTests Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobDeleteCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobCreateCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobCancelCommandTests.cs Updates tests to new command testing base and updated namespaces.
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs Minor formatting update to service method signature for readability.
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/IManagedLustreService.cs Normalizes some service return types and signatures during migration.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/ManagedLustreOptionDescriptions.cs Introduces centralized option description strings for [Option] attributes.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/ManagedLustreOptionDefinitions.cs Removes legacy System.CommandLine-based option definitions.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/SubnetSize/SubnetSizeValidateOptions.cs Converts options to attribute-based POCO implementing ISubscriptionOption.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/SubnetSize/SubnetSizeAskOptions.cs Converts options to attribute-based POCO implementing ISubscriptionOption.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/Sku/SkuGetOptions.cs Converts options to attribute-based POCO implementing ISubscriptionOption.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobGetOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobDeleteOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobCreateOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobCancelOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemUpdateOptions.cs Converts options to attribute-based POCO and updates option property naming.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemListOptions.cs Converts options to attribute-based POCO (subscription + optional RG).
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemCreateOptions.cs Converts options to attribute-based POCO and inlines some option descriptions.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobListOptions.cs Removes legacy list options type (handled by updated get/list behavior).
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobGetOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobDeleteOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobCreateOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobCancelOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobListOptions.cs Removes legacy list options type (handled by updated get/list behavior).
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobGetOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobDeleteOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobCreateOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobCancelOptions.cs Converts options to attribute-based POCO and adds required RG/filesystem fields.
tools/Azure.Mcp.Tools.ManagedLustre/src/Options/BaseManagedLustreOptions.cs Removes legacy base options type derived from SubscriptionOptions.
tools/Azure.Mcp.Tools.ManagedLustre/src/Models/ManagedLustreSkuInfo.cs Updates models to use C# primary constructors.
tools/Azure.Mcp.Tools.ManagedLustre/src/ManagedLustreSetup.cs Updates imports for moved command namespaces (Sku/SubnetSize).
tools/Azure.Mcp.Tools.ManagedLustre/src/GlobalUsings.cs Removes legacy global using for System.CommandLine.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/ManagedLustreJsonContext.cs Updates JSON source-gen registrations to match new result types and formatting options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/ManagedLustreCommonValidators.cs Introduces shared validation helpers for option validation in new command design.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/SubnetSize/SubnetSizeValidateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/SubnetSize/SubnetSizeAskCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/Sku/SkuGetCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobGetCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobDeleteCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobCreateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobCancelCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemUpdateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> with updated validation flow.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemListCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemCreateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> with new validation flow.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobGetCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobDeleteCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobCreateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobCancelCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobGetCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobDeleteCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobCreateCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobCancelCommand.cs Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options.
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/BaseManagedLustreCommand.cs Removes legacy base command implementation that depended on manual binding.
tools/Azure.Mcp.Tools.ManagedLustre/src/Azure.Mcp.Tools.ManagedLustre.csproj Removes System.CommandLine dependency and updates core project reference path.
servers/Azure.Mcp.Server/changelog-entries/1784292789378.yaml Adds changelog entry for Managed Lustre tool changes.

Comment thread servers/Azure.Mcp.Server/changelog-entries/1784292789378.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-managedlustre Azure Managed Lustre

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants