Migrate Event Hubs tools to new tool design#3086
Open
alzimmermsft wants to merge 3 commits into
Open
Conversation
alzimmermsft
requested review from
JasonYeMSFT,
anannya03,
g2vinay,
hallipr,
sandeep-sen and
xirzec
July 17, 2026 18:52
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Event Hubs toolset to the attribute-based options design (auto Register/Bind via [Option]/[OptionContainer]), updating commands/tests/models accordingly to align with the newer SubscriptionCommand<TOptions, TResult> pattern.
Changes:
- Replaced
EventHubsOptionDefinitions+ manualRegisterOptions/BindOptionswith[Option]-attributed option POCOs across Namespace/EventHub/ConsumerGroup commands. - Updated command implementations to the new
SubscriptionCommand<TOptions, TResult>shape and adjusted JSON result models/serialization. - Updated unit tests to use the newer command test base helpers and direct
BindOptionscalls.
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/Namespace/NamespaceUpdateCommandTests.cs | Updates tests to new subscription command test base + direct BindOptions. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/Namespace/NamespaceGetCommandTests.cs | Moves tests to new base and aligns option-name checks with attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/Namespace/NamespaceDeleteCommandTests.cs | Updates tests to new base + strongly-typed response deserialization helper. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/EventHub/EventHubUpdateCommandTests.cs | Switches to subscription command unit test base. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/EventHub/EventHubDeleteCommandTests.cs | Switches to subscription command unit test base. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/ConsumerGroup/ConsumerGroupUpdateCommandTests.cs | Switches to subscription command unit test base. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/ConsumerGroup/ConsumerGroupGetCommandTests.cs | Switches to subscription command unit test base. |
| tools/Azure.Mcp.Tools.EventHubs/tests/Azure.Mcp.Tools.EventHubs.Tests/ConsumerGroup/ConsumerGroupDeleteCommandTests.cs | Switches to subscription command unit test base. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/Namespace/NamespaceUpdateOptions.cs | Converts to [Option] attributes + ISubscriptionOption (+ retry container). |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/Namespace/NamespaceGetOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/Namespace/NamespaceDeleteOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/EventHubsOptionDescriptions.cs | Adds shared option description strings for Event Hubs options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/EventHubsOptionDefinitions.cs | Removes legacy explicit Option<T> definitions. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/EventHub/EventHubUpdateOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/EventHub/EventHubGetOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/EventHub/EventHubDeleteOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/ConsumerGroup/ConsumerGroupUpdateOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/ConsumerGroup/ConsumerGroupGetOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/ConsumerGroup/ConsumerGroupDeleteOptions.cs | Converts to [Option] attributes + ISubscriptionOption. |
| tools/Azure.Mcp.Tools.EventHubs/src/Options/BaseEventHubsOptions.cs | Removes legacy shared options base class. |
| tools/Azure.Mcp.Tools.EventHubs/src/Models/Namespace.cs | Removes explicit JsonPropertyName mapping in favor of source-gen + naming policy. |
| tools/Azure.Mcp.Tools.EventHubs/src/Models/EventHubsSku.cs | Removes explicit JsonPropertyName mapping in favor of source-gen + naming policy. |
| tools/Azure.Mcp.Tools.EventHubs/src/Models/EventHubsModelDefinitions.cs | Removes legacy JSON property-name constants. |
| tools/Azure.Mcp.Tools.EventHubs/src/Models/EventHub.cs | Removes explicit JsonPropertyName mapping in favor of source-gen + naming policy. |
| tools/Azure.Mcp.Tools.EventHubs/src/Models/ConsumerGroup.cs | Removes explicit JsonPropertyName mapping in favor of source-gen + naming policy. |
| tools/Azure.Mcp.Tools.EventHubs/src/GlobalUsings.cs | Removes toolset-global usings for legacy command-line/json usage. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/Namespace/NamespaceUpdateCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and validates via ValidateOptions. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/Namespace/NamespaceGetCommand.cs | Moves to new command base; consolidates single/list result shape. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/Namespace/NamespaceDeleteCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/EventHubsJsonContext.cs | Updates JSON source-gen registrations to match new result types. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/EventHub/EventHubUpdateCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/EventHub/EventHubGetCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/EventHub/EventHubDeleteCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/ConsumerGroup/ConsumerGroupUpdateCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/ConsumerGroup/ConsumerGroupGetCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/ConsumerGroup/ConsumerGroupDeleteCommand.cs | Moves to SubscriptionCommand<TOptions, TResult> and attribute-based options. |
| tools/Azure.Mcp.Tools.EventHubs/src/Commands/BaseEventHubsCommand.cs | Removes legacy Event Hubs command base class. |
| tools/Azure.Mcp.Tools.EventHubs/src/Azure.Mcp.Tools.EventHubs.csproj | Updates core reference style and drops direct System.CommandLine package reference. |
| servers/Azure.Mcp.Server/changelog-entries/1784314320111.yaml | Adds a changelog entry for the Event Hubs tool changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Event Hubs tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline