Fix allocation cleanup in FreeDialogResult#980
Open
sage-mode-hunter wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree [company="BugQore"] |
Author
|
@microsoft-github-policy-service agree company="BugQore" |
Comment on lines
165
to
+168
| { | ||
| for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) | ||
| if (lpDialogResult->lpDialogControlResults) | ||
| { | ||
| delete[] lpDialogResult->lpDialogControlResults[i].lpBin; | ||
| delete[] lpDialogResult->lpDialogControlResults[i].szText; | ||
| for (ULONG i = 0; i < lpDialogResult->ulNumControls; i++) |
Member
There was a problem hiding this comment.
Can you fix the indenting here? - it makes the change look much larger than it actually is
Member
There was a problem hiding this comment.
I think I can approve as soon as the indentation is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects the cleanup logic in FreeDialogResult.
Replace delete[] with delete when destroying _AddInDialogResult, matching its allocation with scalar new.
Release the lpDialogControlResults array after freeing the dynamically allocated members it contains.
These changes make the allocation/deallocation pairs consistent and ensure the dialog result object is fully cleaned up.