[torchlib] Add aten::_grouped_mm ONNX lowering - #3017
Open
TANGBUDU wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a torchlib lowering for
aten::_grouped_mm, addressing #2795.MatMul_grouped_mmremain unaffectedFor an offset tensor whose number of groups is itself dynamic, this PR intentionally does not build a generic loop. A future follow-up could lower that case with
Scan/Loop; the static-group unrolling here follows the direction discussed in #2795.Tests
pytest tests/function_libs/torch_lib/ops_test.py -k grouped_mm -qpytest tests/function_libs/torch_lib/e2e_ops_tests.py -k grouped_mm -qlintrunner -agit diff --check_grouped_mmtests are correctly excluded/skippedI also ran the full torch-lib e2e file on the current PyTorch nightly. It has 5 unrelated failures (STFT graph API, dynamic unbind shape constraints, and SDPA numerical mismatch); all 5 reproduce unchanged on a clean
upstream/maincheckout with this patch stashed.