feat(a365): add typed ExecuteTool schemas - #240
Merged
Nikhil Navakiran (nikhilNava) merged 14 commits intoSep 30, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a44c89d4-df14-4be5-8c3c-938d09824bc9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Nikhil Navakiran (nikhilNava)
marked this pull request as ready for review
September 29, 2026 22:04
Nikhil Navakiran (nikhilNava)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
ajmfehr,
Pujarini Mohapatra (biswapm),
Grant Harris (gwharris7),
Hector Hernandez (hectorhdzg),
Jeremy Voss (jeremydvoss),
Julio Carlos Menendez (juliomenendez),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
September 29, 2026 22:04
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
September 29, 2026 22:05
View session
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation and tests are coherent; only a minor duplicated documentation line remains.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds typed, extensible ExecuteTool argument/result schemas while preserving generic payload serialization.
Changes:
- Adds public schema models, enums, and exports.
- Integrates safe serialization into
ExecuteToolScope. - Adds type-checking, unit coverage, CI validation, and documentation.
| File | Description |
|---|---|
src/a365/tool-call-models.ts |
Defines typed ExecuteTool schemas. |
src/a365/contracts.ts |
Extends tool-call contracts and exports. |
src/a365/message-utils.ts |
Adds typed payload serialization. |
src/a365/scopes/ExecuteToolScope.ts |
Records typed arguments and results. |
src/a365/index.ts |
Exposes A365 schema APIs. |
src/index.ts |
Exposes schemas from the package root. |
test/internal/unit/a365/executeToolJsonModels.test.ts |
Tests models and public exports. |
test/internal/unit/a365/messageUtils.test.ts |
Tests serialization and fallbacks. |
test/internal/unit/a365/scopes.test.ts |
Tests span attribute integration. |
tsconfig.type-tests.json |
Configures focused type checking. |
package.json |
Adds the type-check script. |
.github/workflows/pr-validation.yml |
Runs type checking in CI. |
A365_DOCUMENTATION.md |
Documents typed ExecuteTool usage. |
CHANGELOG.md |
Records the feature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Jackson Weber (JacksonWeber)
previously approved these changes
Sep 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
September 30, 2026 17:45
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Extension data uses a wire format inconsistent with the stated .NET parity, and the documentation contains a duplicated line.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
Jackson Weber (JacksonWeber)
approved these changes
Sep 30, 2026
Nikhil Navakiran (nikhilNava)
deleted the
feature/a365-execute-tool-schemas
branch
September 30, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Validation
Parity with microsoft/opentelemetry-distro-dotnet#149. ETW logger changes are out of scope.