Skip to content

feat(a365): add typed ExecuteTool schemas - #240

Merged
Nikhil Navakiran (nikhilNava) merged 14 commits into
mainfrom
feature/a365-execute-tool-schemas
Sep 30, 2026
Merged

Nikhil Navakiran (nikhilNava) merged 14 commits into
mainfrom
feature/a365-execute-tool-schemas

Conversation

@nikhilNava

Copy link
Copy Markdown
Collaborator

Summary

  • add typed, extensible ExecuteTool argument and result schema models
  • preserve existing generic payload behavior while adding safe typed serialization
  • add focused public type checking and comprehensive schema/scope tests

Validation

  • npm run typecheck:test
  • npm run build
  • npm run docs (existing warnings only)
  • npm run format
  • npm run lint (warnings only)
  • npm run test:unit
  • npm run test:functional
  • npm run test:esm-build

Parity with microsoft/opentelemetry-distro-dotnet#149. ETW logger changes are out of scope.

nikhilc-microsoft and others added 7 commits September 14, 2026 07:06
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a44c89d4-df14-4be5-8c3c-938d09824bc9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation and tests are coherent; only a minor duplicated documentation line remains.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Adds typed, extensible ExecuteTool argument/result schemas while preserving generic payload serialization.

Changes:

  • Adds public schema models, enums, and exports.
  • Integrates safe serialization into ExecuteToolScope.
  • Adds type-checking, unit coverage, CI validation, and documentation.
File Description
src/​a365/​tool-call-models.ts Defines typed ExecuteTool schemas.
src/​a365/​contracts.ts Extends tool-call contracts and exports.
src/​a365/​message-utils.ts Adds typed payload serialization.
src/​a365/​scopes/​ExecuteToolScope.ts Records typed arguments and results.
src/​a365/​index.ts Exposes A365 schema APIs.
src/​index.ts Exposes schemas from the package root.
test/​internal/​unit/​a365/​executeToolJsonModels.test.ts Tests models and public exports.
test/​internal/​unit/​a365/​messageUtils.test.ts Tests serialization and fallbacks.
test/​internal/​unit/​a365/​scopes.test.ts Tests span attribute integration.
tsconfig.type-tests.json Configures focused type checking.
package.json Adds the type-check script.
.github/​workflows/​pr-validation.yml Runs type checking in CI.
A365_DOCUMENTATION.md Documents typed ExecuteTool usage.
CHANGELOG.md Records the feature.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread A365_DOCUMENTATION.md
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Comment thread src/a365/message-utils.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5a6fe74f-97a4-4cf9-921f-2c597ee94adf
Copilot AI balanced review requested due to automatic review settings September 30, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Extension data uses a wire format inconsistent with the stated .NET parity, and the documentation contains a duplicated line.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread src/a365/message-utils.ts
@nikhilNava
Nikhil Navakiran (nikhilNava) merged commit 74f6630 into main Sep 30, 2026
8 checks passed
@nikhilNava
Nikhil Navakiran (nikhilNava) deleted the feature/a365-execute-tool-schemas branch September 30, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants