snp: update family id and image id that to be shared across OpenHCL versions (#4183) - #4185
Merged
Ming-Wei Shih (mingweishih) merged 2 commits intoAug 10, 2026
Conversation
…soft#4183) Remove the version-specific value from family id, making it consistent across all OpenHCL versions (cherry picked from commit 75e780a)
Ming-Wei Shih (mingweishih)
added
the
release_1.8.2607
Copilot started reviewing on behalf of
Ming-Wei Shih (mingweishih)
August 7, 2026 15:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SEV-SNP identity constants emitted into OpenHCL SNP ID blocks so the “family id” no longer encodes a version-specific value, aiming to keep the attestation identity consistent across OpenHCL versions.
Changes:
- Update
SNP_FAMILY_IDbytes to a reserved-zero layout with a single OpenHCL discriminator byte. - Rename/update the
SNP_IMAGE_IDconstant value fromunderhilltoopenhcl. - Update the unit test that pins these constants’ exact byte identities.
Suppressed comments (1)
vm/loader/igvmfilegen/src/snp_id_block.rs:54
SNP_IMAGE_IDis also part of the externally-consumed SNP ID block payload (same asSNP_FAMILY_ID). Adding the same “attestation identity” warning here would make the risk of changing this constant more obvious to future editors.
/// SNP image identifier for OpenHCL guests.
pub const SNP_IMAGE_ID: [u8; 16] = *b"openhcl\0\0\0\0\0\0\0\0\0";
Copilot started reviewing on behalf of
Matt LaFayette (Kurjanowicz) (mattkur)
August 7, 2026 21:46
View session
Contributor
|
Given that this is an SNP-specific change, please look at the failed SNP tests and confirm that this change did not cause or exacerbate the failures. |
Ming-Wei Shih (mingweishih)
changed the title
Contributor
Author
all green |
Matt LaFayette (Kurjanowicz) (mattkur)
approved these changes
Aug 10, 2026
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Contributor
There was a problem hiding this comment.
Approving the clean cherry pick, not commenting on the righteousness of the change.
Matt LaFayette (Kurjanowicz) (mattkur)
requested changes
Aug 10, 2026
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Contributor
There was a problem hiding this comment.
Something's off with our scripts detecting this; one moment
Matt LaFayette (Kurjanowicz) (mattkur)
changed the title
Matt LaFayette (Kurjanowicz) (mattkur)
approved these changes
Aug 10, 2026
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Matt LaFayette (Kurjanowicz) (mattkur)
left a comment
Contributor
There was a problem hiding this comment.
Good to go
Ming-Wei Shih (mingweishih)
merged commit Aug 10, 2026
e7ae29f
into
microsoft:release/1.8.2607
125 of 129 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the version-specific value from family id, making it consistent across all OpenHCL versions
Clean cherry pick of #4183