petri: Copy the igvm file before creating the VM - #4189
Closed
Steven Malis (smalis-msft) wants to merge 2 commits into
Closed
petri: Copy the igvm file before creating the VM#4189Steven Malis (smalis-msft) wants to merge 2 commits into
Steven Malis (smalis-msft) wants to merge 2 commits into
Conversation
Steven Malis (smalis-msft)
added
the
backport_1.8.2607
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Hyper-V Petri backend’s OpenHCL (IGVM) handling to copy the IGVM firmware file into a local/temp path earlier, aiming to avoid accessibility/race issues (e.g., when the source firmware is on a WSL filesystem) during VM creation.
Changes:
- Reordered IGVM copy logic to occur before creating the Hyper-V VM.
- Added/updated comments explaining why the copy needs to occur before VM creation.
Steven Malis (smalis-msft)
enabled auto-merge (squash)
August 7, 2026 19:27
auto-merge was automatically disabled
August 10, 2026 14:25
Pull request was closed
Steven Malis (smalis-msft)
removed
the
backport_1.8.2607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot is hypothesizing that there may be some sort of race condition here. I don't think this hurts to do, and maybe it'll help?