fix(ci): preserve recipe failure diagnostics by martin-kolinek · Pull Request #110 · microsoft/ox-tools

martin-kolinek · 2026-08-28T13:54:04Z

🤖 Fixes CI failures whose useful recipe output could be obscured by a later synthetic failure step. This was exposed by the Windows coverage gate in run 33158834495, where cargo-gamma-rt measured 90.7% against a 90.8% threshold but the failed step did not present that diagnosis clearly.

Changes

propagate Just's captured exit status from the same step that streams the complete recipe output
remove the synthetic follow-up failure step
add exact coverage counts, uncovered source ranges, and explicit no-data diagnostics to cargo-coverage-gate output
run PR and scheduled Codecov uploads under always() when LCOV reports exist
retain the Windows ARM exclusion and avoid empty uploads
update generated workflows, design documentation, tests, and snapshots

Validation

cargo-anvil GitHub artifact unit tests
cargo-anvil generated-workflow snapshot tests
actionlint validation for emitted workflows
cargo-anvil Clippy with warnings denied
cargo-coverage-gate unit and CLI tests
formatting, generated README, and spelling checks

Make the recipe-running step propagate its own exit status, add actionable coverage failure details, and publish completed coverage reports even after failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Codecov Comments Bot (codecov-commenter) · 2026-08-28T14:00:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.7%. Comparing base (ff4aa04) to head (45a1be4).

❌ Your project status has failed because the head coverage (97.7%) is below the target coverage (100.0%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@          Coverage Diff           @@
##            main    #110    +/-   ##
======================================
  Coverage   97.7%   97.7%            
======================================
  Files        286     287     +1     
  Lines      62438   62580   +142     
======================================
+ Hits       61009   61155   +146     
+ Misses      1429    1425     -4

Flag	Coverage Δ
linux	`97.6% <100.0%> (?)`
linux-arm	`97.6% <100.0%> (?)`
windows	`97.9% <100.0%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Exercise multi-file truncation and the exact output limit so arithmetic and comparison mutations cannot survive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Exercise renderer early termination, diagnostic write failures, and empty diagnostic filtering to restore complete patch coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sander Saares (sandersaares)

[Copilot speaking]

Published 9 findings. No finding follows up on an existing discussion thread.

See diagnostics

Diagnostic	Value
Cache	Hit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated no new comments.

fix(ci): preserve recipe failure diagnostics

7a846ba

Make the recipe-running step propagate its own exit status, add actionable coverage failure details, and publish completed coverage reports even after failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

martin-kolinek and others added 2 commits August 28, 2026 16:02

test(coverage-gate): cover diagnostic truncation boundaries

e4d609c

Exercise multi-file truncation and the exact output limit so arithmetic and comparison mutations cannot survive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test(coverage-gate): cover diagnostic edge paths

0d0e8b7

Exercise renderer early termination, diagnostic write failures, and empty diagnostic filtering to restore complete patch coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

martin-kolinek commented Aug 31, 2026

View reviewed changes

Comment thread .github/actions/anvil-run-group/action.yml

martin-kolinek commented Aug 31, 2026

View reviewed changes

Comment thread crates/cargo-anvil/templates/github/pr-impl-workflow.yml Outdated

martin-kolinek commented Aug 31, 2026

View reviewed changes

Comment thread crates/cargo-anvil/docs/design/github.md

fix(anvil): keep generated coverage artifacts consistent

eb9afe5

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

martin-kolinek marked this pull request as ready for review August 31, 2026 13:03

Copilot AI lite review requested due to automatic review settings August 31, 2026 13:03

Merge origin/main into fix-hidden-ci-output

252c329

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Aug 31, 2026

Sander Saares (sandersaares) self-requested a review August 31, 2026 14:39

Sander Saares (sandersaares) approved these changes Sep 1, 2026

View reviewed changes

Merge origin/main and address review feedback

bb8c209

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 1, 2026 08:54

Copilot started reviewing on behalf of martin-kolinek September 1, 2026 08:55 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

Merge latest origin/main into fix-hidden-ci-output

fa30833

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 1, 2026 09:56

Copilot started reviewing on behalf of martin-kolinek September 1, 2026 09:57 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

Comment thread crates/cargo-coverage-gate/src/lcov_cov.rs

fix(coverage-gate): enforce diagnostic line ordering

31b068e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 1, 2026 10:57

Copilot started reviewing on behalf of martin-kolinek September 1, 2026 10:58 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

Merge origin/main into fix-hidden-ci-output

45a1be4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 1, 2026 15:19

Copilot started reviewing on behalf of martin-kolinek September 1, 2026 15:20 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

Uh oh!

Conversation

martin-kolinek commented Aug 28, 2026

Changes

Validation

Uh oh!

Codecov Comments Bot (codecov-commenter) commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Sander Saares (sandersaares) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Codecov Comments Bot (codecov-commenter) commented Aug 28, 2026 •

edited

Loading