Handle loss in stim control flow#3459
Merged
Merged
Conversation
joao-boechat
marked this pull request as ready for review
July 14, 2026 23:14
joao-boechat
force-pushed
the
joaoboechat/handle-loss-in-stim-control-flow
branch
from
July 16, 2026 00:21
f21e914 to
a9917c4
Compare
fedimser
approved these changes
Jul 17, 2026
orpuente-MS
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a REQUIRE statement inside of a PREPARE block, we need to make sure that the targets being required aren't LOSS. If they are, then we have to restart the prepare block instead of just continuing (which is what we currently do).
So for example:
When plotting the histogram for this, we should only see a 0 result, as the loss leads to a retry.
Meanwhile,
should result in an infinite loop as we are always getting loss