[api-extractor] Add support for new TS declaration format when using module resolution 'bundler' or 'nodenext'#4952
Merged
octogonz merged 3 commits intoJun 8, 2026
Conversation
408d0f6 to
b6c910e
Compare
Contributor
Author
|
@octogonz maybe? |
Collaborator
|
I am at a conference this week, but will work on this after. 😊 |
b6c910e to
96ab624
Compare
Contributor
Author
|
@iclanton any chance this could be reviewed as well, it has been pending for a long time. the branch is rebased on latest main |
octogonz
reviewed
Jun 7, 2026
octogonz
reviewed
Jun 7, 2026
octogonz
reviewed
Jun 7, 2026
octogonz
reviewed
Jun 7, 2026
octogonz
approved these changes
Jun 7, 2026
…esolution 'bundler' or 'nodenext'
96ab624 to
78d1027
Compare
Collaborator
|
@bartvandenende-wm Thanks for contributing this fix! ❤️ (Sorry it took so long to get it merged!) |
Collaborator
|
(@bartvandenende-wm It happens I will be in Amsterdam this week for the JSNation conference! Are you guys still based there? My contact info is here: www.octogonz.com ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for new TS declaration format when using module resolution 'bundler' or 'nodenext'
fixes #4899
Details
TS 5.x started to support new
moduleResolutionbundlerandnodenext(ornode16) which changes the behaviour of TS declaration files for arbitrary extensions like.jsonand.css.By enabling the TS allowArbitraryExtensions setting, declaration files can be imported with the new module resolutions but are required to follow the
{file basename}.d.{extension}.tspattern.This PR updates the regex in
ExtractorConfigwhich detect if a file is a declaration file to be inclusive of the new pattern.How it was tested
unit test
Impacted documentation
N/A