fix(rush): default rush-pnpm query commands to recursive#5822
Merged
iclanton merged 2 commits intoJun 7, 2026
Conversation
iclanton
approved these changes
Jun 7, 2026
iclanton
reviewed
Jun 7, 2026
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5035.
What changed
rush-pnpm outdatedandrush-pnpm whyto pass--recursivewhen the caller has not already provided-r/--recursiveor--global.@microsoft/rush.Why
outdatedandwhyare workspace query commands in Rush repos. Without recursive mode, they can query the wrong importer or no importer; defaulting these two commands to recursive mode matches the workaround discussed in #5035 while preserving explicit caller flags.Compatibility / risk
This only changes the default flags for
rush-pnpm outdatedandrush-pnpm why. Explicit recursive flags are preserved, and global outdated checks are left unchanged.Tests
RUSH_ALLOW_UNSUPPORTED_NODEJS=1 node common/scripts/install-run-rush.js build --to @microsoft/rush-lib --verbose- passedgit diff HEAD^..HEAD --check- passedRUSH_ALLOW_UNSUPPORTED_NODEJS=1 node common/scripts/install-run-rush.js test --to @microsoft/rush-lib --verbose- the newRushPnpmCommandLineParser.testpassed; the full suite failed locally under unsupported Node 25.6.1 due unrelatedRushXCommandLinesnapshots expecting mocked Node12.12.12 (LTS)but receiving(unstable).