Skip to content

Replace browser alerts with toast notifications - #1119

Merged
paullizer merged 2 commits into
Developmentfrom
paullizer-issue-739-replace-alerts-with-toasts
Jul 30, 2026
Merged

Replace browser alerts with toast notifications#1119
paullizer merged 2 commits into
Developmentfrom
paullizer-issue-739-replace-alerts-with-toasts

Conversation

@paullizer

Copy link
Copy Markdown
Contributor

Summary

  • add a shared, accessible, XSS-safe showToast() utility for classic, inline, and module scripts
  • replace all 254 executable first-party alert() calls across admin, group, public, workspace, profile, feedback, safety, and control-center flows
  • persist success toasts across immediate reloads/navigation and preserve legacy error variant behavior
  • add functional source-policy coverage, Playwright browser coverage, version 0.250.102, and release notes

Validation

  • python functional_tests/test_browser_alert_replacement.py
  • python -m pytest ui_tests/test_shared_toast_notifications.py -q
  • node --check for all changed JavaScript files
  • revision-scoped scripts/check_xss_sinks.py for all changed browser files
  • staged whitespace and diff checks

Scope

Pinned DataTables vendor bundles are intentionally unchanged; their upstream internal fallback alerts are excluded from the first-party regression policy.

Closes #739

paullizer and others added 2 commits July 30, 2026 15:24
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paullizer
paullizer merged commit ea816ed into Development Jul 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant