Deduplicate HangDump disposal setup

[Amaury Levé (Evangelink)]

Deduplicates the timer teardown and dump-gate claim shared by Dispose() and DisposeAsync() while preserving their synchronous and asynchronous wait behavior.

Closes #10847
Closes #10866

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — 22-Dimension Verdict

Clean mechanical refactor: the duplicated timer-dispose + dump-gate block in Dispose() and DisposeAsync() is extracted into a private helper StopTimersAndClaimDumpGate. Semantics are identical — no behavioral change. The out parameter is the right choice here since the caller needs the captured task. XML comment on the helper is thorough and preserves the original rationale.

No issues found.

#	Dimension	Verdict
1	Algorithmic Correctness	✅ Pass — identical logic, just moved
2	Threading & Concurrency	✅ Pass — lock scope and _dumpTaken assignment unchanged
3	Security & IPC Contract Safety	N/A
4	Public API & Binary Compatibility	✅ Pass — method is private, class is internal
5	Resource Management & IDisposable	✅ Pass — dispose calls unchanged
6	Error Handling & Exceptions	✅ Pass — no change to exception paths
7	Performance & Allocations	✅ Pass — no new allocations
8	Logging & Observability	N/A
9	Configuration & Options	N/A
10	Cross-TFM Correctness	✅ Pass — #if NETCOREAPP guard preserved
11	Localization	N/A
12	Test Coverage	N/A — no testable behavior change
13	Naming & Conventions	✅ Pass — clear method name
14	Code Style & Formatting	✅ Pass
15	XML Documentation	✅ Pass — helper has descriptive comment
16	Nullable Reference Types	✅ Pass — Task? nullability preserved
17	Async Patterns	✅ Pass — no async changes
18	Dependency Injection	N/A
19	MSBuild & Packaging	N/A
20	Backward Compatibility	✅ Pass — internal only
21	Analyzers & Code Fixes	N/A
22	Scope Discipline	✅ Pass — single-concern refactor

Result: No issues. Clean DRY refactor with no behavioral change.

[Copilot]

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Deduplicates HangDump disposal setup without changing synchronous or asynchronous behavior.

Changes:

• Extracts timer teardown and dump-gate claiming into a shared helper.
• Preserves existing task waiting and resource cleanup paths.

File	Description
HangDumpProcessLifetimeHandler.Disposal.cs	Centralizes common disposal setup.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.