Use direct-symbol imports for embeddings/query/podcast in mcp/server.py - #304
Merged
Bernhard Merkle (bmerkle) merged 1 commit intoSep 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns src/typeagent/mcp/server.py with the codebase’s prevailing import-style for a few low-symbol, class-centric modules by switching from module-qualified imports to direct-symbol imports, improving readability and consistency with other consumers.
Changes:
- Replace
typeagent.aitools.embeddingsqualified usage with direct import ofIEmbeddingModel. - Replace
typeagent.knowpro.queryqualified usage with direct import ofQueryEvalContext. - Replace
typeagent.podcasts.podcastqualified usage with direct imports ofPodcastandPodcastMessage.
Collaborator
Author
|
robgruen would you mind taking a look at this one when you get a chance? Thanks! |
mcp/server.py was the lone qualified-import user for these low-symbol modules while every other consumer imports them directly: - aitools.embeddings.IEmbeddingModel (vs. 21 files using direct import) - knowpro.query.QueryEvalContext (vs. 2 files) - podcasts.podcast.PodcastMessage/Podcast (vs. podcast_ingest.py) Brings this file in line with the prevailing convention for these modules. Found via a whole-project import-style scan, tracked in microsoft#298.
Bernhard Merkle (bmerkle)
force-pushed
the
fix-import-style-mcpserver
branch
from
September 26, 2026 07:54
dcf59d6 to
d66b6bb
Compare
Collaborator
Author
|
robgruen rebased onto main — no conflicts. |
robgruen
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp/server.pywas the lone qualified-import user for three low-symbol modules where every other consumer in the codebase uses direct-symbol import:aitools.embeddings.IEmbeddingModel(vs. 21 files using direct import)knowpro.query.QueryEvalContext(vs. 2 files:search.py,storage/memory/reltermsindex.py)podcasts.podcast.PodcastMessage/Podcast(vs.podcast_ingest.py)Test plan
make(format, check on 3.12/3.14, test, build) — 0 pyright errors, 737 passed / 12 skipped, wheel builds