Add --clientProcessId like reference LSP server - #4866
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Open
Add --clientProcessId like reference LSP server#4866Jake Bailey (jakebailey) wants to merge 1 commit into
--clientProcessId like reference LSP server#4866Jake Bailey (jakebailey) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds --clientProcessId support to override the LSP initialization PID used by the parent-process watchdog.
Changes:
- Registers the new CLI flag.
- Prioritizes the CLI PID over the initialization message PID.
- Starts the watchdog immediately when an override is supplied.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+82
to
+84
| if clientProcessID > 0 { | ||
| startParentProcessWatchdog(ctx, stop, clientProcessID) | ||
| return nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4809 by way of adding a flag that can be used to override. With this, the caller can override the parent PID; this is how the reference LSP server works, using the flag if provided, otherwise the init message's.