Remove macOS realpath fast path - #4867
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the nondeterministic macOS realpath fast path, ensuring hard-linked files retain the requested path.
Changes:
- Routes macOS realpath resolution through
filepath.EvalSymlinks. - Restricts the EINTR helper to Linux.
- Adds a concurrent macOS hard-link regression test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/nativepath/realpath_other.go |
Includes macOS in the portable implementation. |
internal/nativepath/realpath_darwin.go |
Removes the F_GETPATH fast path. |
internal/nativepath/realpath_darwin_test.go |
Tests deterministic hard-link resolution. |
internal/nativepath/eintr_unix.go |
Limits the helper to Linux. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Andrew Branch (andrewbranch)
August 10, 2026 18:33
Andrew Branch (andrewbranch)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4262
Closes #4578
This fast path didn't work in the presence of hard links.
The test included here does show the problem on macOS.