Add macOS entitlements before signing - #4868
Merged
Jake Bailey (jakebailey) merged 2 commits intoAug 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds required macOS entitlements to Darwin binaries before internal signing.
Changes:
- Generates and applies a macOS entitlements plist using Quill.
- Verifies entitlements after signing and notarization.
- Adds Quill and its Go dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Herebyfile.mjs |
Applies and verifies macOS entitlements. |
go.mod |
Registers Quill as a Go tool. |
go.sum |
Records Quill dependency checksums. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Andrew Branch (andrewbranch)
August 11, 2026 03:03
Andrew Branch (andrewbranch)
approved these changes
Aug 11, 2026
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
This works on my Mac.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Aug 11, 2026
Jake Bailey (jakebailey)
deleted the
jabaile/issue-4854-macos-entitlements
branch
August 11, 2026 20:30
Jake Bailey (jakebailey)
added a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4854
Signing entitlements are kept if they are set before we hand signing off to the internal signing system.
Since I still want the build to be simple, use https://github.com/anchore/quill to do this instead of somehow getting a macOS runner into the build in the right place (annoying for moving artifacts around). Adds a load of deps, unfortunately. Probably could
-modfileit later.I need to test this on a real run.