fix(compiler): improve error message when --emit specifies an uninstalled emitter - #11485
Open
timotheeguerin with Copilot wants to merge 2 commits into
Open
fix(compiler): improve error message when --emit specifies an uninstalled emitter#11485timotheeguerin with Copilot wants to merge 2 commits into
timotheeguerin with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
… emitter When running `tsp compile . --emit not-installed-emitter`, the error message now reports a more helpful `emitter-not-found` diagnostic with a suggestion to install the package, instead of the generic `import-not-found` error. Closes #1982 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error message for
fix(compiler): improve error message when --emit specifies an uninstalled emitter
Jul 30, 2026
--emit invalid-emitter
microsoft-github-policy-service
Bot
added
the
compiler:core
commit: |
timotheeguerin
marked this pull request as ready for review
July 30, 2026 16:41
timotheeguerin
requested review from
catalinaperalta,
iscai-msft,
markcowl and
xirzec
as code owners
July 30, 2026 16:41
|
You can try these changes here
|
timotheeguerin
enabled auto-merge
July 30, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsp compile . --emit not-installed-emitterpreviously emitted a genericimport-not-founderror with no actionable guidance. It now reports a dedicatedemitter-not-founddiagnostic with an install hint.Before:
After:
Changes
messages.ts: Newemitter-not-founddiagnostic code with a message that names the emitter and includes annpm installhint.program.ts:loadLibraryaccepts an optional{ isEmitter }context flag; when set and the underlying error isimport-not-found, it reportsemitter-not-foundinstead.loadEmitterpasses{ isEmitter: true }.--emit invalid-emitterdoesn't give the best error message #1982