fix(vscode): terminate both debug sessions together when debugging the extension - #11511
Open
timotheeguerin wants to merge 2 commits into
Open
fix(vscode): terminate both debug sessions together when debugging the extension#11511timotheeguerin wants to merge 2 commits into
timotheeguerin wants to merge 2 commits into
Conversation
…e extension Closing the Extension Development Host window ended the client session without a manual stop, which the compound's stopAll does not cover, leaving the attached language server running. Add cascadeTerminateToConfigurations so the attach session is torn down with it, and stopAll on the compound so stopping either session ends both instead of leaving an orphan in the Call Stack view.
Contributor
|
No changes needing a change description found. |
timotheeguerin
marked this pull request as ready for review
July 31, 2026 15:50
timotheeguerin
requested review from
catalinaperalta,
iscai-msft,
markcowl and
xirzec
as code owners
July 31, 2026 15:50
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging the VS Code extension leaves orphaned debug sessions behind.
The
VS Code Extensioncompound launches two sessions: the extension host client and an attach to the language server. Ending the debug session the usual way — closing the Extension Development Host window — terminates the client without going through a manual stop, so the language server session keeps running and lingers in the Call Stack view. You then have to stop it by hand before the nextF5, and stale servers accumulate across iterations.Two small config additions fix it:
cascadeTerminateToConfigurationson VS Code Extension (Client) tears down the attach session when the extension host window closes. The compound'sstopAllalone does not cover this case, because closing the window is not a stop request.stopAll: trueon the VS Code Extension compound makes stopping either session terminate both, so neither can be orphaned.Now
F5→ close the dev host window returns you to a clean Call Stack every time.